Record classes are now handled the same as normal classes

[jannisCode]

What it does

Record classes are now handled the same way as normal classes.
This bug fix was proposed here: #1813

Before

Record classes were not checked for the amount of parameters which their methods had. Normal classes where though. That posed the problem, that when only one argument was given, the code minings were shown for record classes but not for normal classes.

How to test

Use this code snippet:

import java.util.Objects;

class Main {
	public static void main(String...args) {
		Car c = new Car(3);
		Cat car = new Cat(5);
		car.equals(c);
		car.doSomething(12, 13);
	}
}

 class Cat {
    private int size;

    public Cat(int size) {
        this.size = size;
    }
    public Cat(long age) {}

    public int getSize() {
        return size;
    }

    public void doSomething(int a, int b) {}
    @Override
    public boolean equals(Object obj) {
        if (this == obj) return true;
        if (obj == null || getClass() != obj.getClass()) return false;
        Cat cat = (Cat) obj;
        return size == cat.size;
    }

    @Override
    public int hashCode() {
        return Objects.hash(size);
    }

    @Override
    public String toString() {
        return "Cat{size=" + size + "}";
    }
}

public record Car(int side) {}

it will result in this:

After the changes

Record classes are checked for the number of parameters the same way as normal classes and methods are checked. For the discussion on when they should be checked please take a look at #1813 (comment) and feel free to tell us your opinion.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[fedejeanne]

LGTM.

[fedejeanne]

@jukzi would you kindly (review and) merge this?

I don't have commit rights :-)

[jukzi]

The code change looks good, but it would be better if you could add a junit test to avoid regression. Can you work on that?

[eclipse-jdt-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.text.tests/META-INF/MANIFEST.MF
org.eclipse.jdt.text.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 2b73646777d63531bdf3935852e981274885e210 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Tue, 3 Dec 2024 14:25:32 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/org.eclipse.jdt.text.tests/META-INF/MANIFEST.MF b/org.eclipse.jdt.text.tests/META-INF/MANIFEST.MF
index 5fa7dbb471..b3b6d006ff 100644
--- a/org.eclipse.jdt.text.tests/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.text.tests/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.text.tests
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.jdt.text.tests;singleton:=true
-Bundle-Version: 3.14.600.qualifier
+Bundle-Version: 3.14.700.qualifier
 Bundle-Activator: org.eclipse.jdt.text.tests.JdtTextTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
diff --git a/org.eclipse.jdt.text.tests/pom.xml b/org.eclipse.jdt.text.tests/pom.xml
index 67c19fdd52..e2192b0866 100644
--- a/org.eclipse.jdt.text.tests/pom.xml
+++ b/org.eclipse.jdt.text.tests/pom.xml
@@ -20,7 +20,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.text.tests</artifactId>
-  <version>3.14.600-SNAPSHOT</version>
+  <version>3.14.700-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[jukzi]

redundant new line

[jannisCode]

fixed it!

[jukzi]

LGTM, manually tested, that the test fails without the change.
thanks for contributing.

[jukzi]

unrelated build error, i don't know how to handle that
00:05:04.844 Caused by: org.apache.maven.plugin.MojoFailureException: Version has moved backwards for (org.eclipse.jdt.core.manipulation/1.21.300.v20241101-2227). Baseline has 1.21.300.v20241108-2119) with delta: 0.0.0
lets try rebase.

[jukzi]

There will be unrelated know 12 fails #1833 that can be ignored today

[fedejeanne]

There will be unrelated know 12 fails #1833 that can be ignored today

so.... merge? :-)