Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ClassCastException in ContinuousTypingCompletionTest #1835 #1837

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Dec 5, 2024

AsyncCompletionProposalPopup defers the actual
AbstractJavaCompletionProposal proposals. Test has to wait for async proposals to be calculated.

#1835

@jukzi jukzi added test junit test related things regression Regression defect labels Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

…1835

AsyncCompletionProposalPopup defers the actual
AbstractJavaCompletionProposal proposals. Test has to wait for async
proposals to be calculated.

eclipse-jdt#1835
@jukzi jukzi force-pushed the ContinuousTypingCompletionTest branch from 990f7ac to 0fa87e7 Compare December 6, 2024 07:46
@jukzi
Copy link
Contributor Author

jukzi commented Dec 6, 2024

ignoring unrelated know 12 fails #1833

@jukzi jukzi merged commit 30d7c1d into eclipse-jdt:master Dec 6, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression defect test junit test related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants