Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug 96932 #1840

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix Bug 96932 #1840

merged 1 commit into from
Dec 6, 2024

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Dec 6, 2024

What it does

Fixes Bug 96932. See issue.

How to test

See issue or new tests.

Author checklist

- properly check context in an enum method before offering to create a
  new enum constant and possibly offer a new field or constant instead
- add new tests to UnresolvedVariablesQuickFixTest
- fixes eclipse-jdt#1839
@jjohnstn jjohnstn self-assigned this Dec 6, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Dec 6, 2024
@jjohnstn jjohnstn added this to the 4.35 M1 milestone Dec 6, 2024
@jjohnstn
Copy link
Contributor Author

jjohnstn commented Dec 6, 2024

Failures are known problem introduced by Platform. PR has been reverted but failures will occur until next I-build.

@jjohnstn jjohnstn merged commit c2e1f6f into eclipse-jdt:master Dec 6, 2024
7 of 10 checks passed
@jjohnstn jjohnstn deleted the enumfield branch December 6, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug 96932 - [quick fix] No "create field" quick fix inside enum
1 participant