Null check annotations for Semantic Tokens API #1852
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downstream plugins using the new
ISemanticTokensProvider
API and having JDTnull
analysis turned on having issues compiling classes deriving from theISemanticTokensProvider
. Whether I add@Nullable
or@NonNull
the class still fails to compile withAdding the
@NonNull
for the return type and the parameter sets the proper API expectations as well as hopefully would help sorting the downstream compiler errors out.