Increase timeout in FatJarExporTests to reduce the chances of tests failing randomly on slow hardware #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure documented in #811 |
fedejeanne
force-pushed
the
bugs/699-Failure_of_test_FatJarExportTests.exportInternalLib
branch
from
d5a48e0 to
c991cd9
Compare
|
The Build failure seems unrelated: 15:39:38 [ERROR] Cannot resolve dependencies of MavenProject: org.eclipse.ltk:org.eclipse.ltk.core.refactoring:3.14.100-SNAPSHOT @ /home/jenkins/agent/workspace/eclipse.jdt.ui-github_PR-808/org.eclipse.ltk.core.refactoring/pom.xml: See log for details
15:39:38 org.eclipse.tycho.DependencyResolutionException: Cannot resolve dependencies of MavenProject: org.eclipse.ltk:org.eclipse.ltk.core.refactoring:3.14.100-SNAPSHOT @ /home/jenkins/agent/workspace/eclipse.jdt.ui-github_PR-808/org.eclipse.ltk.core.refactoring/pom.xml |
|
/rebase |
Give it a max of 30s per test instead of 5s. This doesn't slow down the tests execution, it just lets the tests run a bit longer if the hardware is slow. Fixes eclipse-jdt#699
github-actions
bot
force-pushed
the
bugs/699-Failure_of_test_FatJarExportTests.exportInternalLib
branch
from
c991cd9 to
536311c
Compare
fedejeanne
deleted the
bugs/699-Failure_of_test_FatJarExportTests.exportInternalLib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Increase timeout to 30s per test instead of 5s. This doesn't slow down the tests execution, it just lets the tests run a bit longer if the hardware is slow.
Fixes #699
How to test
Run the tests in
org.eclipse.jdt.ui.tests.jarexport.FatJarExportTests, they should pass.Author checklist
✔️ I have thoroughly tested my changes
✔️ The change is following the coding conventions
✔️ I have signed the Eclipse Contributor Agreement (ECA)