Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target platform's junit dependencies to the latest available #106

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Aug 15, 2024

@merks
Copy link
Contributor Author

merks commented Aug 15, 2024

@iloveeclipse

This build will not actually test anything that's actually changed.

This is needed for

eclipse-platform/eclipse.platform.releng.aggregator#2225

which will fail the same way as

eclipse-platform/eclipse.platform.releng.aggregator#2221

until the JDT feature that includes the junit dependencies is touched.


Both @laeubi and I were wondering if it's really necessary for the JDT feature to include all these bundles. Perhaps the includes are redundant because the other included bundles transitively require these unit bundles. Failing that, could imports be used instead.

@akurtakov
Copy link
Contributor

Let's merge it now.

@akurtakov akurtakov merged commit 3f74aad into eclipse-jdt:master Aug 15, 2024
3 checks passed
@merks merks deleted the pr-tp-junit branch August 15, 2024 06:20
@iloveeclipse
Copy link
Member

wondering if it's really necessary for the JDT feature to include all these bundles. Perhaps the includes are redundant because the other included bundles transitively require these unit bundles. Failing that, could imports be used instead.

Could you please open a PR for that? I honestly don't know, there are always some corner cases that nobody is aware of until it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants