Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ltk from the JDT.setup's requirements #74

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 11, 2023

This fixes the project setup to remove requirements on tests no longer in the jdt.ui repository.

eclipse-jdt/eclipse.jdt.ui#852

@merks
Copy link
Contributor Author

merks commented Oct 11, 2023

@mickaelistria

This has no build impact, so in such cases I generally just cancel the build to "save the environment".

@mickaelistria
Copy link
Contributor

@merks ack.

@merks
Copy link
Contributor Author

merks commented Oct 11, 2023

I'm not a committer so you merging it will be great! This was quite a painless migration. 😄

@iloveeclipse iloveeclipse merged commit b0dd61d into eclipse-jdt:master Oct 11, 2023
1 check passed
@mickaelistria
Copy link
Contributor

Ah sorry, I didn't grok the underlying request to merge; but I'm not a committer either on JDT ;)
Thanksfully, @iloveeclipse already did it.

@merks merks deleted the pr-ltk-setup branch October 11, 2023 15:14
@merks
Copy link
Contributor Author

merks commented Oct 11, 2023

Thanks guys! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants