generated from EclipseFdn/.eclipsefdn-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable merge commits for jdt-incubator #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge commit would make further attempt to merge it in upstream JDT harder. Let's disable those. Signed-off-by: Mickael Istria <mistria@redhat.com>
This comment has been minimized.
This comment has been minimized.
@fbricon @rgrunber @gorkem @testforstephen I think this requires a project lead approval. Can you please review? |
netomi
reviewed
Feb 12, 2024
PR updates make rebase/review easier without necessarily involving the submitter for a rebase. Signed-off-by: Mickael Istria <mistria@redhat.com>
Diff for 426af2f:Printing local diff:
Actions are indicated with the following symbols:
+ create
! modify
! forced update
- delete
Organization eclipse.jdt.ls[id=eclipse-jdtls]
there have been 3 validation infos, enable verbose output with '-v' to to display them.
! repository[name="eclipse-jdt-core-incubator"] {
! allow_merge_commit = true -> false
! allow_update_branch = false -> true
! }
Plan: 0 to add, 2 to change, 0 to delete. Canonical Diff for 426af2f:Showing canonical diff:
Organization eclipse.jdt.ls[id=eclipse-jdtls]
--- canonical
+++ original
@@ -3,8 +3,6 @@
orgs.newOrg('eclipse-jdtls') {
_repositories+:: [
orgs.newRepo('eclipse-jdt-core-incubator') {
- allow_merge_commit: false
- allow_update_branch: true
default_branch: "master"
delete_branch_on_merge: false
dependabot_alerts_enabled: false
@@ -13,7 +11,6 @@
secret_scanning_push_protection: "disabled"
web_commit_signoff_required: false
workflows+: {
- actions_can_approve_pull_request_reviews: false
default_workflow_permissions: "write"
}
}
@@ -85,9 +82,6 @@
secret: "********"
}
]
- workflows+: {
- actions_can_approve_pull_request_reviews: false
- }
}
]
secrets+: [ |
fbricon
approved these changes
Feb 12, 2024
netomi
approved these changes
Feb 12, 2024
changes are live. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge commit would make further attempt to merge it in upstream JDT harder. Let's disable those.