Revert "Fixes eclipse-jdt#3213 - NPE and stack overflow protection"

This reverts commit 97de32f.

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java

@@ -1711,9 +1711,6 @@ public RecordComponentBinding getComponent(char[] componentName, boolean needRes
 // NOTE: the return type, arg & exception types of each method of a source type are resolved when needed
 @Override
 public MethodBinding[] getMethods(char[] selector) {
-	return getMethods(selector, true);
-}
-public MethodBinding[] getMethods(char[] selector, boolean shouldTryAgain) {
 	if (!isPrototype())
 		return this.prototype.getMethods(selector);
 
@@ -1743,11 +1740,8 @@ public MethodBinding[] getMethods(char[] selector, boolean shouldTryAgain) {
 		for (int i = start; i <= end; i++) {
 			MethodBinding method = this.methods[i];
 			if (resolveTypesFor(method) == null || method.returnType == null) {
-				if( shouldTryAgain ) {
-					methods();
-					return getMethods(selector, false); // try again since the problem methods have been removed
-				}
-				return new MethodBinding[0];
+				methods();
+				return getMethods(selector); // try again since the problem methods have been removed
 			}
 		}
 		int length = end - start + 1;
@@ -1763,11 +1757,8 @@ public MethodBinding[] getMethods(char[] selector, boolean shouldTryAgain) {
 				? method.areParameterErasuresEqual(result[j])
 				: method.areParametersEqual(result[j]);
 			if (paramsMatch) {
-				if( shouldTryAgain ) {
-					methods();
-					return getMethods(selector); // try again since the duplicate methods have been removed
-				}
-				return new MethodBinding[0];
+				methods();
+				return getMethods(selector); // try again since the duplicate methods have been removed
 			}
 		}
 	}
@@ -2078,9 +2069,6 @@ private int getImplicitMethod(MethodBinding[] resolvedMethods, char[] name) {
 // NOTE: the return type, arg & exception types of each method of a source type are resolved when needed
 @Override
 public MethodBinding[] methods() {
-	if( this.scope == null ) {
-		return new MethodBinding[0];
-	}
 
 	components(); // In a record declaration, the components should be complete prior to fields and probably for methods
 
@@ -2555,10 +2543,6 @@ public FieldBinding resolveTypeFor(FieldBinding field) {
 }
 
 public MethodBinding resolveTypesFor(MethodBinding method) {
-	if( scope == null ) {
-		return null;
-	}
-
 	ProblemReporter problemReporter = this.scope.problemReporter();
 	try {
 		IErrorHandlingPolicy suspendedPolicy = problemReporter.suspendTempErrorHandlingPolicy();