Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack to prevent OperationCanceledException from being propagated to logs #1052

Open
wants to merge 802 commits into
base: dom-with-javac
Choose a base branch
from
Open

Hack to prevent OperationCanceledException from being propagated to logs #1052

wants to merge 802 commits into from

Conversation

datho7561
Copy link

No description provided.

@datho7561 datho7561 force-pushed the dom-with-javac-cancellation-hack branch 2 times, most recently from 4beec1c to 2510c10 Compare December 12, 2024 15:01
mickaelistria and others added 26 commits December 13, 2024 13:14
@mickaelistria @datho7561
Inspect nested diagnostic in some cases
bb6b65e 
It may provide finer grain information (eg allows to distinguish permits
vs sealed issues)
@datho7561
Mostly fix test109
1d45639 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix several tests with malformed package declarations
7f9e6eb 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix testBug347100
34f79dd 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Cleanup and a small fix
e548e03 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
test annotations
62d3a5b 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix test83804 and test83804a - incorrect source ranges / lengths
eef403c 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Ignore testBug103304 - violates javadoc spec
edb8500 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix testBug113108b - three slash comments should be Line Comments
2d14293 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria @datho7561
Improve problem conversion to UndefinedName
fbc13a4 
And trim out some non-compatible args from problem arguments.
@mickaelistria @datho7561
Fix converting problems about accessing static members
9e92c3c
@mickaelistria @datho7561
Better map UndefinedConstructor problem
dc708a6
@datho7561
Map error for diamond op on non generic type
bbf10f8 
eg.
```java
Object asdf = new Object<>();
```

Also fixes the quickfix to remove it.

Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria @datho7561
Improve JavacBindingResolver.resolveExpressionType()
8116c30
@datho7561
Fix some more error ids
a772716 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Fix testBug87845 - varargs in javadoc method ref parameters
43e2acf 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix testBug79809 - type parameter javadoc test; previous fix insuffic…
14b7697 
…ient

Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria @datho7561
Better map missing method diagnostic and related bindings
20b30d2
@mickaelistria @datho7561
Fix potential exception in JavacTypeBinding
7ea4df9
@mickaelistria @datho7561
Bump parent pom version to 4.34
5d7c4b6
@mickaelistria @datho7561
Use some TreeInfo utils instead of custom code
c7b39e3
@datho7561
Some more problem ids
435bb58 
Signed-off-by: David Thompson <davthomp@redhat.com>
@akurtakov @datho7561
Map compiler.warn.try.explicit.close.call problem
bc68b78
@akurtakov @datho7561
Code cleanups
6d56a4e
@testforstephen @datho7561
Use variable kind to check if it qualifies for unused checker (eclips…
d1f660e 
…e-jdt#801)
@mickaelistria @datho7561
Fix type name position
fa02daa
mickaelistria and others added 26 commits December 13, 2024 13:14
@mickaelistria @datho7561
Fix some inner class not being copied
afc8457 
In some cases (such as switch expressions), Javac generates some extra
.class files of nested anonymous types. Those are only created duing the
"generate" phase, and are not detected during "analyze"; so we add in
the listener for Generate ability to record such newly generated
classes.

Fixes eclipse-jdtls#1014
@mickaelistria @datho7561
Revert "Don't adjust cursor offset when finding node to complete"
44f49db 
This reverts commit 170822b.
And it adapts it so that the if the resulting node after adjust is not a
SimpleName or a Literal (ie is structured), then this previous node is
used as context
@mickaelistria @datho7561
Fix some contextCompletionTests (to 73)
93eca27 
Most issues related to token and positions are covered.
@datho7561
Improve attached import completion for type completions
0a83428 
Only do it when the type isn't in the same class and use `null` instead
of a 0 length array

Signed-off-by: David Thompson <davthomp@redhat.com>
@mickaelistria @datho7561
Some work on expected types (down to 49 failures)
e6b774d
@mickaelistria @datho7561
Fix more CompletionContextTests (down to 43)
d297bac
@datho7561
Handle match files in the order they arrived
2d3d38e 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Ensure all parent nodes fully encompass their child nodes
c5f8ac1 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Ensure calls to ASTParser.createBindings use the correct unit resolver
418af84 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
null check before passing a new TypeBinding to requestor
e0238db 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Missing names must have length 0, not length 7 representing <error>
59f0ba5 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fixes to VariableDeclaration completion
fd61bbf 
- select the correct node to complete when working with variable
  declarations
- for FieldDeclarations, don't allow using declarations that occur after
  the current declaration when completing the initializer
  (eg. do not suggest `c` nor `b` in `int a = 1; int b = |; int c = 3;`)
  - also handle field declarations with multiple variable declaration
    fragments properly
    (eg. allow `a` as a completion in: `int a = 2, b = |`)

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Handle qualification when calculating relevance
51b4a72 
I think I'm missing some edge cases, but this should fix a few cases.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Do not double-propose types
5bb61f8 
Sometimes, types were collected by the scrapeBindings method and the
type search.
This PR prevents suggesting the type from the type search if it was
already suggested through publishFromScope

Should fix ~10 test cases

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Fix ASTConverter18Test.test0009 - illegal argument
5cfa787 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria @datho7561
Keep cached filesystems uniniterruptible
9a402b4 
ZipFileSystem can have its underlying channel closed if a consuming
thread was interrupted while reading (eg aborted hover).
Override the fileManager so that the channel is not closed.
@mickaelistria @datho7561
Fix position for ArrayInitializer
ed51848
@datho7561
Fix NPE in testBug424138_001 and others; bad synchronized block
a9d3f0c 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
Fix regressions ASTConverterAST3Test.test0009 and others; also Cleanup
8c3f447 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@datho7561
NPE check in DOMCompletionEngine when erasure is null
41d975f 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria @datho7561
CompletionContextTest: null token after string literal
5792237
@datho7561
Translate problem id for unknown annotation member
cac14f7 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Fixes eclipse-jdt#1038 - regression during some error syntax
29c5db2 
Signed-off-by: Rob Stryker <stryker@redhat.com>
@mickaelistria @datho7561
Used Resolved* JavaElement in Javac*Bindings.getJavaElement()
5ffc118 
Those allow to store a more accurate key.
@snjeza @datho7561
javac doesn't configure output folders of dependent projects correctly
3a31441 
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@datho7561
Completion for favourite static imports
cc0dccd 
Should get all the "favourite static imports" tests passing;
around 33 new passing tests and no regressions.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Hack to prevent OperationCanceledException from being propagated to logs
8cfd179 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the dom-with-javac-cancellation-hack branch from 2510c10 to 8cfd179 Compare December 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelistria mickaelistria Awaiting requested review from mickaelistria

Assignees

@datho7561 datho7561

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@datho7561 @mickaelistria @akurtakov @testforstephen @snjeza