New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes testBug519493_003 - module binding on class symbol #612

Open

robstryker wants to merge 437 commits into eclipse-jdtls:dom-with-javac from robstryker:testBug519493_003

robstryker commented Jul 19, 2024

No description provided.

github-actions bot assigned robstryker

mickaelistria commented Jul 19, 2024

This seems to introduce some new failures:

diff head-sorted robs-sorted 
797a798,808
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0002
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0003
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0004
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0005
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0006
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0007
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0008
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0009
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0004
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0006
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0009
1354c1365
<     javac specific tests / org.eclipse.jdt.core.tests.dom.ASTConverter9Test.testBug519493_003
---
>     javac specific tests / org.eclipse.jdt.core.tests.dom.ASTConverter9Test.testBug519493_002

Let's first rebase to check whether those vanish.

akurtakov force-pushed the dom-with-javac branch from 7fa6490 to d4193c8 Compare

July 19, 2024 20:15

robstryker force-pushed the testBug519493_003 branch from 2dd9a99 to 193c59d Compare

July 25, 2024 14:35

Author

robstryker commented Jul 25, 2024

When I run these tests locally, I'm not seeing much of a difference at all between with the PR or without the PR. This is very strange.

mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from c02519d to e65aeb8 Compare

July 25, 2024 22:05

gayanper and others added 23 commits

July 29, 2024 07:44


          fix review comments

c341229


          DOMToIndex: restore statements

a6b5cee


          fill in record components in record declaration

217b56c


          Report Javadoc problems as warnings for most severe

9c40eb0

Errors from javadoc look out of place for now.
Maybe in the future if/when there are settings for each of them they can
be switched back to errors depending on settings.


          [DOM based index] Prevent some deadlock

f00a7a6

Prevents from searching in index which index is being built.


          Fix JavacMethodBinding for non-DOM references

b07f300

methods that are not declared in current file.


          Endless loop - nextToken() is identical for ever and ever

829691f

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix for test0126 - String[] v[] not represented correctly when part o…

4c2cbe0

…f for-loop

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix for test0126 - String v[] not represented correctly when part of …

e89a377

…assignment

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix for test0314 - String v[] has off-by-one error

057906d

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Partial Fix for test0321 - new Object[][] has off-by-one error in dim…

08c80e6

…ensions

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Partially fix testBug531714_015 - switch(i) { case 1 -> list } needs …

96e8219

…yield statement Part 1 and 2

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix testBug519493_002 - TypeParameter needs a type binding

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Add support for Module Binding

ac16c23

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix testTypeBindingMethods - type binding parameters are wrong

fb61014

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix testBug526534_0001 - class cast exception

b64d549

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix testBug519493_006 - module binding

25697bf

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix testBug519493_005 - type binding needs access to module

539fb49

Signed-off-by: Rob Stryker <stryker@redhat.com>


          More work on JavacModuleBinding regarding key and annotations

f67805e

Signed-off-by: Rob Stryker <stryker@redhat.com>


          partial fix to testBug497719_0001 - modifiers missing on try with res…

ede9ff1

…ources

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix ASTConverter15JLS4Test.test0140 dom portion

3ebc452

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fix ASTConverter15JLS4Test.test0140 binding portion

7d8998c

Signed-off-by: Rob Stryker <stryker@redhat.com>


          [javac] More binding fixes

034040f

Signed-off-by: David Thompson <davthomp@redhat.com>

mickaelistria and others added 9 commits

July 29, 2024 07:44


          Fix diagnostic position for TypeMismatch with fieldAccess

7c3ab28

+ map incompatible types in for-each problem


          Cleanup unused code in JavacConverter


          Better support mapping multi-field declaration in enums

9ce71e2

And annotation, record, implicit...

Fix eclipse-jdtls#640


          Interface have no superclass

06e224a

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Anonymous classes have no superclass

0adcae5

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Better implementation for JavacTypeBinding.getTypeParameters()

ee2dacd


          Fix error range for @OverRide on non-inherited method

c0d50ff

This allows the quickfix to remove it to work

Signed-off-by: David Thompson <davthomp@redhat.com>


          fix random completion errors including eclipse-jdt#634

ccbbec8


          Map some more problems

d1f814c

akurtakov force-pushed the dom-with-javac branch from 612291f to d1f814c Compare

July 29, 2024 04:45

akurtakov and others added 4 commits

July 29, 2024 17:07


          Fix ASTConverter_GuardedPattern_Test.testGuardedPattern001

e6b9727


          Move problem messaging mappings to test bundle

3cd2c1c

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Add way to getJavaElement for working copy files, and fix several

0a724af

binding issues regarding generics

Signed-off-by: Rob Stryker <stryker@redhat.com>

Fixes ASTConverter15JLS4Test.test0071

Signed-off-by: Rob Stryker <stryker@redhat.com>

More fixes to test0070 and test0071

Signed-off-by: Rob Stryker <stryker@redhat.com>

Cleanup

Signed-off-by: Rob Stryker <stryker@redhat.com>


          Fixes testBug519493_003 - module binding on class symbol

72837e7

Signed-off-by: Rob Stryker <stryker@redhat.com>

robstryker force-pushed the testBug519493_003 branch from 193c59d to 72837e7 Compare

July 30, 2024 20:41

Author

robstryker commented Jul 30, 2024

Rebased, Will investigate what it does to tests.

akurtakov force-pushed the dom-with-javac branch from 2b02636 to a40c063 Compare

August 16, 2024 10:37

mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from 13a7ce9 to 911e4b3 Compare

September 10, 2024 08:43

mickaelistria force-pushed the dom-with-javac branch 3 times, most recently from 16bd705 to 9fb5696 Compare

September 25, 2024 06:20

mickaelistria force-pushed the dom-with-javac branch from 7b4b9ad to e230daa Compare

October 15, 2024 09:24

rgrunber force-pushed the dom-with-javac branch from 0575d89 to 6dd73f3 Compare

October 18, 2024 13:40

mickaelistria force-pushed the dom-with-javac branch from df710af to fbcc030 Compare

October 23, 2024 23:04

mickaelistria force-pushed the dom-with-javac branch from 2ad1e11 to f45e071 Compare

November 12, 2024 10:22

mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from 7f5c20a to 87832d6 Compare

December 6, 2024 13:52

datho7561 force-pushed the dom-with-javac branch from aa3b08f to cc0dccd Compare

December 13, 2024 18:57

mickaelistria force-pushed the dom-with-javac branch from 7e220b3 to 525cd23 Compare

December 15, 2024 09:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet