Work on Matchlocator and dom #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstryker
force-pushed
the
matchlocator-dom
branch
2 times, most recently
from
6b6aa0d to
97de32f
Compare
| @@ -327,6 +327,11 @@ public char[] getContents() { | |||
| public CompilationUnit originalFromClone() { | |||
| return CompilationUnit.this; | |||
| } | |||
| @Override | |||
There was a problem hiding this comment.
Was submitted here: eclipse-jdt#3216
| @@ -79,6 +83,30 @@ public IPath getPath() { | |||
| return this.classFile.getPath(); | |||
| } | |||
|
|
|||
| @Override | |||
| public char[] getFileName(){ | |||
There was a problem hiding this comment.
Was submitted here: eclipse-jdt#3216
|
Would it be possible to merge all the changes under org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/matching/ soon? Does that allow some more tests to pass? |
robstryker
force-pushed
the
matchlocator-dom
branch
2 times, most recently
from
3188702 to
b9c0918
Compare
* Fix javadoc test 001 and others Signed-off-by: Rob Stryker <stryker@redhat.com> * Fix javadoc test000 Signed-off-by: Rob Stryker <stryker@redhat.com> * More work on javadoc tests Signed-off-by: Rob Stryker <stryker@redhat.com> * More fixes to javadoc Signed-off-by: Rob Stryker <stryker@redhat.com> * Substantial fix for testBug54424, and fixes several unknown others Signed-off-by: Rob Stryker <stryker@redhat.com> --------- Signed-off-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Rob Stryker <stryker@redhat.com>
- Fix quickfix for "Create provider method" by adjusting the
error range of
"service implementation missing no-args constructor or provider method"
to match that of ECJ's
to see this quickfix in action, setup the following three files and open
quickfixes on the error in the `module-info.java`.
```java
module myModular {
provides test.IFoo with test.Foo;
}
```
```java
package test;
public interface IFoo{}
```
```java
package test;
public class Foo implements test.IFoo {
public Foo(String asdf) {}
}
```
Signed-off-by: David Thompson <davthomp@redhat.com>
Sometimes, the name has no symbol attached, while the "main" parent that is defined by the name as one. So we try to resolve parent structure when we couldn't resolve on name.
binary name is only equivalent to signature for primitive types. For regular named types, the flatname is better
- Fix a small bug in the AST - Fix some problem ids - Fix some diagnostic ranges Signed-off-by: David Thompson <davthomp@redhat.com>
Better resolve hosting compilationUnit
Signed-off-by: Rob Stryker <stryker@redhat.com>
…arations Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
added 2 commits
December 2, 2024 14:12
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
matchlocator-dom
branch
from
c35043f to
58dfa22
Compare
added 4 commits
December 2, 2024 14:14
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
matchlocator-dom
branch
4 times, most recently
from
4472f4b to
d2f8726
Compare
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
robstryker
force-pushed
the
matchlocator-dom
branch
4 times, most recently
from
d510fe7 to
78addb8
Compare
added 2 commits
December 2, 2024 16:00
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
matchlocator-dom
branch
3 times, most recently
from
6d50f14 to
f9e50b6
Compare
Signed-off-by: Rob Stryker <stryker@redhat.com> Small change as per suggestion Signed-off-by: Rob Stryker <stryker@redhat.com> Oops - merge error Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
dom-with-javac
branch
from
f546e96 to
95178a7
Compare
added 2 commits
December 2, 2024 16:41
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
matchlocator-dom
branch
from
f9e50b6 to
f55b9c3
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
7f5c20a to
87832d6
Compare
datho7561
force-pushed
the
dom-with-javac
branch
from
aa3b08f to
cc0dccd
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7e220b3 to
525cd23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes primarily fix how the new match locating functions with the existing ECJ infrastructure, and as such, the fixes may or may not be noticable in this automated build.