feature: Generate Dash License Report #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: eclipse-kuksa#24 Signed-off-by: Andre Weber <andre.weber3@etas.com>
Chrylo
approved these changes
Nov 16, 2023
|
LGTM |
|
I feel part of this might use the shared action here https://github.com/eclipse-kuksa/kuksa-actions/tree/main/check-dash @erikbosch might advise |
erikbosch
reviewed
Nov 16, 2023
.github/workflows/dash.yaml
Outdated
| run: ./gradlew mergeDashFiles | ||
|
|
||
| - name: Dash license check | ||
| uses: ./.github/actions/check-dash |
There was a problem hiding this comment.
Check and see if you can use uses: eclipse-kuksa/kuksa-actions/check-dash@2
If so we do not need to add check-dash in this repo.
There was a problem hiding this comment.
Good find! We also need to align this on the SDK-side as well, because the SDK also stores it's own dash-action right now.
Replaced it as suggested.
|
Also check the PR here: eclipse-kuksa/kuksa-android-sdk#38 |
|
@SebastianSchildt @erikbosch As soon as you think this looks fine you can merge this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3