test: Add test for updating an invalid VssModel value

eclipse-kuksa · Mar 18, 2024 · b3d887c · b3d887c
1 parent 461eda0
commit b3d887c
Showing 1 changed file with 25 additions and 11 deletions.
diff --git a/...sdk/src/test/kotlin/org/eclipse/kuksa/connectivity/databroker/DataBrokerConnectionTest.kt b/...sdk/src/test/kotlin/org/eclipse/kuksa/connectivity/databroker/DataBrokerConnectionTest.kt
@@ -153,22 +153,36 @@ class DataBrokerConnectionTest : BehaviorSpec({
         and("A VssNode") {
             val vssDriver = VssDriver()
 
-            `when`("Fetching the node") {
+            and("A default HeartRate") {
+                val newHeartRateValue = 60
+                val datapoint = Types.Datapoint.newBuilder().setUint32(newHeartRateValue).build()
+                val defaultUpdateRequest = UpdateRequest(vssDriver.heartRate.vssPath, datapoint)
 
-                and("The initial value is different from the default for a child") {
-                    val newHeartRateValue = 60
-                    val datapoint = Types.Datapoint.newBuilder().setUint32(newHeartRateValue).build()
-                    val updateRequest = UpdateRequest(vssDriver.heartRate.vssPath, datapoint)
+                dataBrokerConnection.update(defaultUpdateRequest)
 
-                    dataBrokerConnection.update(updateRequest)
+                `when`("Fetching the node") {
 
-                    val fetchRequest = VssNodeFetchRequest(vssDriver)
-                    val updatedDriver = dataBrokerConnection.fetch(fetchRequest)
+                    and("The initial value is different from the default for a child") {
+                        val fetchRequest = VssNodeFetchRequest(vssDriver)
+                        val updatedDriver = dataBrokerConnection.fetch(fetchRequest)
 
-                    then("Every child node has been updated with the correct value") {
-                        val heartRate = updatedDriver.heartRate
+                        then("Every child node has been updated with the correct value") {
+                            val heartRate = updatedDriver.heartRate
 
-                        heartRate.value shouldBe newHeartRateValue
+                            heartRate.value shouldBe newHeartRateValue
+                        }
+                    }
+                }
+
+                `when`("Updating the node with an invalid value") {
+                    val invalidHeartRate = VssDriver.VssHeartRate(-5) // UInt on DataBroker side
+                    val vssNodeUpdateRequest = VssNodeUpdateRequest(invalidHeartRate)
+                    dataBrokerConnection.update(vssNodeUpdateRequest)
+
+                    val fetchRequest = VssNodeFetchRequest(invalidHeartRate)
+                    val fetchedVssHeartRate = dataBrokerConnection.fetch(fetchRequest)
+                    then("the updated value should be ignored") {
+                        fetchedVssHeartRate.value shouldBe 60
                     }
                 }
             }