Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Certificate Selectable in TestApp #21

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Make Certificate Selectable in TestApp #21

merged 6 commits into from
Oct 13, 2023

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Oct 12, 2023

Closes: #15

Chrylo
Chrylo requested changes Oct 12, 2023
View reviewed changes
app/src/test/kotlin/org/eclipse/kuksa/testapp/model/ConnectionInfoTest.kt Show resolved Hide resolved
app/src/test/kotlin/org/eclipse/kuksa/testapp/model/ConnectionInfoTest.kt Show resolved Hide resolved
app/src/test/kotlin/org/eclipse/kuksa/testapp/model/ConnectionInfoTest.kt Outdated Show resolved Hide resolved
app/src/main/kotlin/org/eclipse/kuksa/testapp/databroker/view/FileSelectorSettingView.kt Outdated Show resolved Hide resolved
app/src/main/kotlin/org/eclipse/kuksa/testapp/databroker/view/FileSelectorSettingView.kt
@Preview
@Composable
fun FileSelectorSettingPreview() {
FileSelectorSettingView(label = "Certificate", value = "CA.pem") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm,... I don't see the typo, please elaborate here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic :O

@Chrylo
Copy link
Contributor

Chrylo commented Oct 13, 2023

LGTM

  • Ran Unit Tests
  • Testes cert upload + connection

@lukasmittag
Copy link
Contributor

So it works but if I use a file that does not work it will just timeout. As user I would want to know that it times out because of my wrong file or because I didn't specify one. Otherwise it looks good.

@wba2hi
Copy link
Contributor Author

wba2hi commented Oct 13, 2023

So it works but if I use a file that does not work it will just timeout. As user I would want to know that it times out because of my wrong file or because I didn't specify one. Otherwise it looks good.

Unfortunately we don't get that info. We only get the "ConnectionState" (IDLE, CONNECTED, CLOSED,...) to verify if the channel to the DataBroker is connected. We can roll that part up again and see if we can improve the "how to connect"-logic but this would be part of a separate ticket.

@lukasmittag
Copy link
Contributor

Understood okay :)

lukasmittag
lukasmittag approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What I did:

  • tested uploading certificates and using them (false and right ones)

@lukasmittag lukasmittag merged commit bfbdee2 into eclipse-kuksa:main Oct 13, 2023
3 checks passed
@erikbosch erikbosch deleted the feature-15 branch October 31, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag lukasmittag approved these changes

@Chrylo Chrylo Chrylo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestApp: Make Certificate selectable from device
3 participants
@wba2hi @Chrylo @lukasmittag