-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TP] update to Eclipse 4.30 and latest versions of other dependencies #1609
Conversation
cabad2e
to
bad345a
Compare
No, for BIRT and WTP, someone else did the work. Maybe these changes will give inspiration: |
86fd54f
to
45f61a8
Compare
I guess you hold off updating guava until this is done? https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/12173 |
Actually I wanted to include the Guava update, but have to admit that I forgot it. Thanks for the heads up. But with that issue open, I'll postpone this to another PR. |
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
@HannesWell what do you think about replace guava cache with the alternative you mentioned recently? |
45f61a8
to
f164227
Compare
I would be in favor of that and already did that in #507, but it was not fully working and parts of it were reverted in #928. But as mentioned there, I assume that with small extra steps it can still be done without Guava. See also #1288. |
f164227
to
d61a057
Compare
@laeubi do you have any idea why the new bnd version generates he packages javax.lang.model.element, java.lang.annotation, java.lang on Jenkins but only (the old packages) |
I just remmber that I needed to adjusted Tycho tests to include the new packages, it could be that Tycho is using a cached variant so maybe you need to delete the caches here: |
OK, thanks for the hint. |
d61a057
to
2968bc5
Compare
For the migration of the test HttpServer the Jetty migration see: https://eclipse.dev/jetty/documentation/jetty-12/programming-guide/index.html#pg-migration-11-to-12-servlet-to-handler
2968bc5
to
b04eb93
Compare
Looks like that was it. 🎉 |
Create this update for now as a draft to test compatibility with the upcoming release.