Extract maven-resolver-api from the embedded runtime bundle #1770
Conversation
Test Results 214 files ±0 214 suites ±0 12m 0s ⏱️ - 8m 12s For more details on these failures and errors, see this check. Results for commit 9df7271. ± Comparison against base commit 9955a22. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
extract_resolver_api
branch
from
08a84f8 to
4211ad1
Compare
There was a problem hiding this comment.
We can try that, but I would be in favor to do it after the upcoming release for the 24-06 SimRel.
I have no clue if maven-core works that well if the resolve is not on the same flat classpath.
The bundle has indeed OSGi metadata, but I would be (positively) surprised if everything works already.
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/wildwebdeveloper/releases/1.3.4/"/> | ||
| <repository location="https://download.eclipse.org/tm4e/releases/0.11.0/"/> | ||
| <repository location="https://download.eclipse.org/lsp4e/releases/0.26.0/"/> | ||
| <repository location="https://download.eclipse.org/lsp4j/updates/releases/0.22.0/"/> | ||
| <repository location="https://download.eclipse.org/mylyn/updates/release/4.2.0/"/> | ||
| <unit id="org.eclipse.wildwebdeveloper.xml.feature.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.lsp4e" version="0.0.0"/> | ||
| </location> |
There was a problem hiding this comment.
Could you please revert the formatting changes that also remove comments.
The Target Editor unfortunately does not respect the existing element order.
There was a problem hiding this comment.
I can do that but on the long run we either should not put comments in the target or enhance PDE to retain them in some way otherwise one is always forced to do text-editing targets
laeubi
force-pushed
the
extract_resolver_api
branch
from
4211ad1 to
b59ae06
Compare
I marked this as draft as it is more an experiment now :-)
I don't think its a big issue as its all only API, but realized that this will require to change all bundles previously requiring |
laeubi
force-pushed
the
extract_resolver_api
branch
2 times, most recently
from
a604c4c to
8b8001b
Compare
laeubi
force-pushed
the
extract_resolver_api
branch
from
8b8001b to
a467b14
Compare
Currently we embed the maven-resolver-api jar into m2e, but the API itself is already a bundle an we should consume it as such so we can: 1) update it independently 2) make it reusable by others without require the full runtime 3) cut down the size of the runtime bundle
laeubi
force-pushed
the
extract_resolver_api
branch
from
a467b14 to
9df7271
Compare
Currently we embed the maven-resolver-api jar into m2e, but the API itself is already a bundle an we should consume it as such so we can: