Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify pgp sign" #1858

Conversation

HannesWell
Copy link
Contributor

This reverts change in pgp-signing done in the commits ca976ab and
1dd211b

This reverts change in pgp-signing done in the commits
ca976ab and
1dd211b
Copy link

github-actions bot commented Oct 3, 2024

Test Results

  321 files  ±0    321 suites  ±0   58m 4s ⏱️ + 8m 15s
  678 tests ±0    657 ✅ +1  18 💤 ±0  2 ❌ ±0  1 🔥  - 1 
2 034 runs  ±0  1 976 ✅ ±0  54 💤 ±0  3 ❌ +1  1 🔥  - 1 

For more details on these failures and errors, see this check.

Results for commit 16753b4. ± Comparison against base commit 4e83fd3.

@HannesWell
Copy link
Contributor Author

The simplification was not impossible but just broken because of a typo, that was fixed in #1859.
So this is obsolete.

@HannesWell HannesWell closed this Oct 3, 2024
@HannesWell HannesWell deleted the revert-signing-simplification branch October 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant