Always configure JRE container to be the highest environment from #843
Conversation
m-compile-p and m-enforcer-p parametrisation This closes eclipse-m2e#842
| @@ -198,6 +201,24 @@ public void configure(ProjectConfigurationRequest request, IProgressMonitor moni | |||
| MavenJdtPlugin.getDefault().getBuildpathManager().updateClasspath(project, monitor); | |||
| } | |||
|
|
|||
| static String getHighestEnvironmentId(String... environmentIds) { | |||
There was a problem hiding this comment.
Where could I put a unit test for this (no IT necessary, no bundling into an Eclipse plugin either)? m2e.jdt.tests also only contains package o.e.m.jdt.tests and this test would need to be located in the same package.
There was a problem hiding this comment.
The approach from https://stackoverflow.com/a/44926613 seems reasonable to me but as only the reactor has a pom.xml one would need to generally enable that....
There was a problem hiding this comment.
o.e.m.jdt.tests would be the best place. As the class is internal you could make the method static.
Another approach, that m2e is not leveraging yet so it may require more work to get started, is https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#execute-unit-tests-with-eclipse-plugin-packaging
|
As discussed in #842 (comment) different compiler settings for test and compile are not supported by Eclipse and having a lower enforced minimum Java version than compile target would be a bug in the |
m-compile-p and m-enforcer-p parametrisation
This closes #842