(0.43) Initialize recycled continuations in createContinuation before usage #18658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, recycled continuations are reset and initialized in
freeContinuation
at the end of their use. There are also gaps wherethe recycled continuation might retain old values and not be properly
reset.
The above approach leads to corruption and segfaults as seen in
the
runJavaThread
failure reported in #16728.To fix the above crash, all continuations (new and recycled) are
initialized and reset in
createContinuation
just before thecontinuation begins execution.
Related: #16728