Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.43) Initialize recycled continuations in createContinuation before usage #18658

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

babsingh
Copy link
Contributor

Currently, recycled continuations are reset and initialized in
freeContinuation at the end of their use. There are also gaps where
the recycled continuation might retain old values and not be properly
reset.

The above approach leads to corruption and segfaults as seen in
the runJavaThread failure reported in #16728.

To fix the above crash, all continuations (new and recycled) are
initialized and reset in createContinuation just before the
continuation begins execution.

Related: #16728

Currently, recycled continuations are reset and initialized in
freeContinuation at the end of their use. There are also gaps where
the recycled continuation might retain old values and not be properly
reset.

The above approach leads to corruption and segfaults as seen in
the runJavaThread failure reported in eclipse-openj9#16728.

To fix the above crash, all continuations (new and recycled) are
initialized and reset in createContinuation just before the
continuation begins execution.

Related: eclipse-openj9#16728

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
Depends on
- eclipse-openj9/openj9#18649
- eclipse-openj9/openj9#18657
- eclipse-openj9/openj9#18658

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
Depends on
- eclipse-openj9/openj9#18649
- eclipse-openj9/openj9#18657
- eclipse-openj9/openj9#18658

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Dec 19, 2023
Depends on
- eclipse-openj9/openj9#18649
- eclipse-openj9/openj9#18657
- eclipse-openj9/openj9#18658

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@pshipton pshipton merged commit 3d9125c into eclipse-openj9:v0.43.0-release Dec 19, 2023
2 checks passed
JasonFengJ9 pushed a commit to adoptium/aqa-tests that referenced this pull request Dec 20, 2023
JasonFengJ9 pushed a commit to adoptium/aqa-tests that referenced this pull request Dec 20, 2023
JasonFengJ9 pushed a commit to adoptium/aqa-tests that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants