Code Cleanup in pde.core: Edits

eclipse-pde · Aug 21, 2023 · bd2a980 · bd2a980
1 parent ae5e4d4
commit bd2a980
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/...ipse.pde.core/src/org/eclipse/pde/internal/core/builders/ExtensionPointSchemaBuilder.java b/...ipse.pde.core/src/org/eclipse/pde/internal/core/builders/ExtensionPointSchemaBuilder.java
@@ -70,6 +70,7 @@ public boolean visit(IResourceDelta delta) {
 			}
 
 			if (resource instanceof IFile candidate) {
+				// see if this is it
 				if (isSchemaFile(candidate)) {
 					// That's it, but only check it if it has been added or changed
 					if (delta.getKind() != IResourceDelta.REMOVED) {

diff --git a/...clipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureConsistencyChecker.java b/...clipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureConsistencyChecker.java
@@ -49,6 +49,7 @@ public boolean visit(IResourceDelta delta) {
 			IResource resource = delta.getResource();
 
 			if (resource instanceof IProject project) {
+				// Only check projects with feature nature
 				try {
 					return (project.hasNature(PDE.FEATURE_NATURE));
 				} catch (CoreException e) {
@@ -57,6 +58,7 @@ public boolean visit(IResourceDelta delta) {
 				}
 			}
 			if (resource instanceof IFile candidate) {
+				// see if this is it
 				if (isManifestFile(candidate)) {
 					// That's it, but only check it if it has been added or changed
 					if (delta.getKind() != IResourceDelta.REMOVED) {

diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/UpdateSiteBuilder.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/UpdateSiteBuilder.java
@@ -46,6 +46,7 @@ public boolean visit(IResourceDelta delta) {
 			IResource resource = delta.getResource();
 
 			if (resource instanceof IProject project) {
+				// Only check projects with feature nature
 				try {
 					return (project.hasNature(PDE.SITE_NATURE));
 				} catch (CoreException e) {
@@ -54,6 +55,7 @@ public boolean visit(IResourceDelta delta) {
 				}
 			}
 			if (resource instanceof IFile candidate) {
+				// see if this is it
 				if (candidate.getName().equals("site.xml")) { //$NON-NLS-1$
 					// That's it, but only check it if it has been added or changed
 					if (delta.getKind() != IResourceDelta.REMOVED) {

diff --git a/...rg.eclipse.pde.core/src/org/eclipse/pde/internal/core/project/ProjectModifyOperation.java b/...rg.eclipse.pde.core/src/org/eclipse/pde/internal/core/project/ProjectModifyOperation.java
@@ -517,6 +517,7 @@ private void configureManifest(IBundleProjectDescription description, IBundlePro
 			}
 		}
 		if (pluginBase instanceof IFragment fragment) {
+			// host specification
 			IHostDescription host = description.getHost();
 			if (!isEqual(host, before.getHost())) {
 				fragment.setPluginId(host.getName());