Skip to content

Commit

Permalink
FeatureErrorReporter.validatePluginExists should recognized fragments
Browse files Browse the repository at this point in the history
The validator currently produces an error when it find the referenced
plugin but the plugin is a fragment. This is wrong behavior for the
latest implementation that makes no distinction between plugins versus
fragments.

#915
  • Loading branch information
merks authored and HannesWell committed Nov 13, 2023
1 parent af86173 commit dc480ed
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ private void validatePluginExists(Element element, Attr attr) {
int severity = CompilerFlags.getFlag(fProject, CompilerFlags.F_UNRESOLVED_PLUGINS);
if (severity != CompilerFlags.IGNORE) {
IPluginModelBase model = PluginRegistry.findModel(id);
if (model == null || !model.isEnabled() || model.isFragmentModel()) {
if (model == null || !model.isEnabled()) {
VirtualMarker marker = report(NLS.bind(PDECoreMessages.Builders_Feature_reference, id), getLine(element, attr.getName()), severity, PDEMarkerFactory.CAT_OTHER);
addMarkerAttribute(marker, PDEMarkerFactory.compilerKey, CompilerFlags.F_UNRESOLVED_PLUGINS);
}
Expand Down

0 comments on commit dc480ed

Please sign in to comment.