Random failing UpdateUnitVersionsCommandTests

[jukzi]

https://download.eclipse.org/eclipse/downloads/drops4/R-4.28-202306050440/testresults/html/org.eclipse.pde.genericeditor.extension.tests_ep428I-unit-win32-java17_win32.win32.x86_64_17.html

ID: org.eclipse.fake.7 has the incorrect version. expected:<[1.0.0.v2]> but was:<[0.0.0]>

org.junit.ComparisonFailure: ID: org.eclipse.fake.7 has the incorrect version. expected:<[1.0.0.v2]> but was:<[0.0.0]>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.confirmVersionUpdates(UpdateUnitVersionsCommandTests.java:92)
at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.testVersionSort(UpdateUnitVersionsCommandTests.java:55)

[jukzi]

same in
https://download.eclipse.org/eclipse/downloads/drops4/I20241118-0600/testresults/html/org.eclipse.pde.genericeditor.extension.tests_ep434I-unit-macosx-aarch64-java17_macosx.cocoa.aarch64_17.html

[jukzi]

Enhanced info from https://download.eclipse.org/eclipse/downloads/drops4/I20241120-0600/testresults/html/org.eclipse.pde.genericeditor.extension.tests_ep434I-unit-macosx-aarch64-java17_macosx.cocoa.aarch64_17.html

org.junit.ComparisonFailure: ID: org.eclipse.fake.6 has the incorrect version. updatedText=<target>
<locations>
<location>
<unit id="org.eclipse.fake.1" version="0.0.0"/>
<unit id="org.eclipse.fake.2" version="0.0.0"/>
<unit id="org.eclipse.fake.3" version="0.0.0"/>
<unit id="org.eclipse.fake.4" version="0.0.0"/>
<unit id="org.eclipse.fake.5" version="0.0.0"/>
<unit id="org.eclipse.fake.6" version="0.0.0"/>
<unit id="org.eclipse.fake.7" version="0.0.0"/>
<repository location="bundleentry://349.fwk733886212/testing-files/testing-sites/MultipleUnitsConfirmSorting/"/>
</location>
</locations>
</target> expected:<[1.1]0.0> but was:<[0.]0.0>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.confirmVersionUpdates(UpdateUnitVersionsCommandTests.java:93)
at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.testVersionSort(UpdateUnitVersionsCommandTests.java:55)

[jukzi]

the string is calculated in UpdateUnitVersions.java:

[jukzi]

A version of 0 could means org.eclipse.pde.internal.genericeditor.target.extension.model.RepositoryCache.fetchP2UnitsFromRepos(List<String>)
may have not returned any version. Potential Exceptions are ignored in
org.eclipse.pde.internal.genericeditor.target.extension.model.RepositoryCache.getFutureValue() and not even logged.

[jukzi]

The result version are stored in org.eclipse.equinox.internal.p2.metadata.repository.LocalMetadataRepository.units, which is only partially accessed with "synchronized"