Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepositoryCache: log exceptions of futures #666 #1494

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Nov 26, 2024

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2eb672881102eadbb9b298c4b04303bee8fe0782 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Tue, 26 Nov 2024 16:04:34 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
index 121014c534..8142015e91 100644
--- a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension;singleton:=true
-Bundle-Version: 1.2.500.qualifier
+Bundle-Version: 1.2.600.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jface.text,
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   279 files   -   6     279 suites   - 6   47m 49s ⏱️ - 9m 41s
 3 586 tests ±  0   3 509 ✅  -   1   76 💤 ± 0  1 ❌ +1 
10 756 runs   - 194  10 553 ✅  - 166  202 💤  - 29  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 72bc1f5. ± Comparison against base commit 5ab1e21.

@jukzi
Copy link
Contributor Author

jukzi commented Nov 27, 2024

Interestingly the windows verification build failed exactly the junit test that i want to improve, but did not log any usefull error :-(

2024-11-26T16:25:05.4675307Z org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.testUpdateRequired -- Time elapsed: 0.369 s
2024-11-26T16:25:05.4677564Z org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.testVersionSort -- Time elapsed: 0.102 s <<< FAILURE!
2024-11-26T16:25:05.4679086Z org.junit.ComparisonFailure: 
2024-11-26T16:25:05.4679760Z ID: org.eclipse.fake.2 has the incorrect version. updatedText=<target>
2024-11-26T16:25:05.4680325Z <locations>
2024-11-26T16:25:05.4680591Z <location>
2024-11-26T16:25:05.4680910Z <unit id="org.eclipse.fake.1" version="0.0.0"/>
2024-11-26T16:25:05.4681414Z <unit id="org.eclipse.fake.2" version="0.0.0"/>
2024-11-26T16:25:05.4681879Z <unit id="org.eclipse.fake.3" version="0.0.0"/>
2024-11-26T16:25:05.4682353Z <unit id="org.eclipse.fake.4" version="0.0.0"/>
2024-11-26T16:25:05.4682861Z <unit id="org.eclipse.fake.5" version="0.0.0"/>
2024-11-26T16:25:05.4683332Z <unit id="org.eclipse.fake.6" version="0.0.0"/>
2024-11-26T16:25:05.4683807Z <unit id="org.eclipse.fake.7" version="0.0.0"/>
2024-11-26T16:25:05.4687175Z <repository location="bundleentry://369.fwk1932663416/testing-files/testing-sites/MultipleUnitsConfirmSorting/"/>
2024-11-26T16:25:05.4688417Z </location>
2024-11-26T16:25:05.4688677Z </locations>
2024-11-26T16:25:05.4689468Z </target> expected:<[1.2].0> but was:<[0.0].0>
2024-11-26T16:25:05.4690011Z 	at org.junit.Assert.assertEquals(Assert.java:117)
2024-11-26T16:25:05.4691839Z 	at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.confirmVersionUpdates(UpdateUnitVersionsCommandTests.java:93)
2024-11-26T16:25:05.4694669Z 	at org.eclipse.pde.genericeditor.extension.tests.UpdateUnitVersionsCommandTests.testVersionSort(UpdateUnitVersionsCommandTests.java:55)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants