Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Adapt license-check to its move to own eclipse-dash organization #1337

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[Build] Adapt license-check to its move to own eclipse-dash organization #1337

merged 1 commit into from
Jul 13, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell
Copy link
Member Author

License check passed. Submitting.

@HannesWell HannesWell merged commit 7dd9db5 into eclipse-pde:master Jul 13, 2024
10 of 11 checks passed
@HannesWell HannesWell deleted the fix-license-check branch July 13, 2024 12:17
@HannesWell
Copy link
Member Author

HannesWell commented Jul 13, 2024 •
edited
Loading

@laeubi can you tell what the advantage of having the license check and request for licensing vetting split in different workflows?
From my perspective it just makes maintenance harder since more than one file handles license checking.

See #1338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HannesWell