-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use try-with-resource #604
Conversation
@@ -1,5 +1,5 @@ | |||
/******************************************************************************* | |||
* Copyright (c) 2008, 2009 IBM Corporation and others. | |||
* Copyright (c) 2008, 2023 IBM Corporation and others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - updating this year is optional; I personally find it a waste of effort. If you like to do this, that is fine but in case you also find it non-value add, you can skip this step.
@iloveeclipse freeze period is already over or is the calender broken again? @HannesWell Maybe we could move the usage of the freeze check to use something in our repo so that we have better access to it? Like a json file defining the dates. |
The calendar is here: https://calendar.google.com/calendar/embed?src=prfk26fdmpru1mptlb06p0jh4s%40group.calendar.google.com&ctz=Europe%2FParis according to that we are in a Quiet period (only "stabilization", "signoff" or "promotion" ar considere "freeze-days"). |
Test Results 240 files ±0 240 suites ±0 58m 23s ⏱️ + 5m 54s For more details on these errors, see this check. Results for commit 25f6550. ± Comparison against base commit e382788. ♻️ This comment has been updated with latest results. |
I would prefer to have a single source of truth and if the calender is needed for other things, I would just keep it. Btw. the workflow prints a link to the console to access the calender in the Browser. |
to close streams.
only unrelated random fail #261 on win |
Random failing tests are with us for too long and these improvements should help to reduce "randomness" in the long term thus please merge. |
to close streams.