Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use try-with-resource #604

Merged
merged 4 commits into from
Jun 12, 2023
Merged

use try-with-resource #604

merged 4 commits into from
Jun 12, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jun 6, 2023

to close streams.

@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2008, 2009 IBM Corporation and others.
* Copyright (c) 2008, 2023 IBM Corporation and others.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - updating this year is optional; I personally find it a waste of effort. If you like to do this, that is fine but in case you also find it non-value add, you can skip this step.

@vogella
Copy link
Contributor

vogella commented Jun 6, 2023

@iloveeclipse freeze period is already over or is the calender broken again? @HannesWell Maybe we could move the usage of the freeze check to use something in our repo so that we have better access to it? Like a json file defining the dates.

@laeubi
Copy link
Contributor

laeubi commented Jun 6, 2023

The calendar is here: https://calendar.google.com/calendar/embed?src=prfk26fdmpru1mptlb06p0jh4s%40group.calendar.google.com&ctz=Europe%2FParis according to that we are in a Quiet period (only "stabilization", "signoff" or "promotion" ar considere "freeze-days").
If required I think it makes much sense to ask the calendar maintainers to give access to project leads and share a link that can be used to import the calendar e.g. in Thunderbird, and alike...

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

     240 files  ±0       240 suites  ±0   58m 23s ⏱️ + 5m 54s
  3 278 tests ±0    3 252 ✔️  - 1  24 💤 ±0  0 ±0  2 🔥 +1 
10 131 runs  ±0  10 057 ✔️  - 1  72 💤 ±0  0 ±0  2 🔥 +1 

For more details on these errors, see this check.

Results for commit 25f6550. ± Comparison against base commit e382788.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

Maybe we could move the usage of the freeze check to use something in our repo so that we have better access to it? Like a json file defining the dates.

I would prefer to have a single source of truth and if the calender is needed for other things, I would just keep it.
If necessary I agree that increasing the number of people with write access would be better.

Btw. the workflow prints a link to the console to access the calender in the Browser.

@jukzi
Copy link
Contributor Author

jukzi commented Jun 9, 2023

only unrelated random fail #261 on win
mind to merge?

@akurtakov
Copy link
Member

Random failing tests are with us for too long and these improvements should help to reduce "randomness" in the long term thus please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants