Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bumps for 4.30 stream #737

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

alshamams
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Test Results

     246 files  +    9       246 suites  +9   1h 1m 8s ⏱️ + 4m 19s
  3 299 tests +124    3 273 ✔️ +  98  24 💤 +24  1 +1  1 🔥 +1 
10 194 runs  +372  10 120 ✔️ +298  72 💤 +72  1 +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit db83edb. ± Comparison against base commit 5defc43.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

pde.api.tools has to be bumped too:

Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.2:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.pde.api.tools: Only qualifier changed for (org.eclipse.pde.api.tools/1.3.100.v20230906-1344). Expected to have bigger x.y.z than what is available in baseline (1.3.100.v20230829-0851) -> [Help 1]

@akurtakov
Copy link
Member

api.tools handled in separate commit. Let's see whether smth else is needed here.

@alshamams
Copy link
Contributor Author

Hi @akurtakov ,
In the list of features tagged against PDE in the linked issue, namely, org.eclipse.pde, org.eclipse.pde.doc.user, org.eclipse.pde.feature.jar, org.eclipse.pde.source and org.eclipse.pde.source.feature.jar, I was only able to locate the changes in org.eclipse.pde feature. Which are the other files to be changed ? Or will the changes in the other features be automatically applied when this change is carried over to releng aggregator repo ?

@akurtakov
Copy link
Member

The list there was not full. One should always look at the latest I-build results e.g. https://download.eclipse.org/eclipse/downloads/drops4/I20230907-1800/buildlogs/reporeports/reports/versionChecks.html . In this case the build was failing with the error I posted so it was obvious what has to be done. The extra change I did can be seen from the linked PR to this one.

@akurtakov akurtakov merged commit d6bd4d7 into eclipse-pde:master Sep 8, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants