Merge AllPDEMinimalTests into AllPDETests and merge minimal tests #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Test Results 270 files + 24 270 suites +24 1h 1m 35s ⏱️ + 5m 48s For more details on these failures and errors, see this check. Results for commit af10a51. ± Comparison against base commit ba4fde8. This pull request removes 575 and adds 610 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
mergeMinimalTests
branch
7 times, most recently
from
32f49b5 to
faa7acd
Compare
This prevents future and resolves already existing discrepancies between the tests run in the verification-builds and I-builds. All tests executed in verification builds should also run in I-builds. Only those that cannot succeed in verification builds are dynamically disable using JUnit-Assume. With this the 'AllPDETests' test-suite can be now be executed in verification builds. This also fixes the ConvertProjectToPluginTestCase for verification builds and runs the full PluginRegistryTests and ClasspathContributorTest which passes without changes.
and make it work in verification tests and fix source-attachment assertion. Add Plug-ins to import from the runtime as dependencies of the Test-Plugin in order to ensure they are available in the test-runtime.
HannesWell
force-pushed
the
mergeMinimalTests
branch
from
faa7acd to
af10a51
Compare
I double checked it and effectively this change only adds new tests that are executed and removes none (some are effectively re-named). |
This was referenced Sep 17, 2023
|
Ideally all those tests that are now disabled dynamically are fixed to work in verification builds (and executed as JUnit Plugin Test from the Workspace). But that's a task for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents (and resolves already existing) discrepancies between the tests run in the verification-builds and I-builds. All tests executed in verification builds should also run in I-builds.
Only those that cannot succeed in verification builds are dynamically disable using JUnit-Assume.
With that just the AllPDETests test-suite can be executed.
The discrepancies were about to get more in #497 or #743 because people just check the verification builds, if their test was really executed.
@vik-chand you split up those tests a while ago and I saw that you also tried to use Assumptions (at least they were in the tests as comments). Can you tell why you didn't continue with that approach?