Run/ Debug Configurations tab Plug-ins issue #311

[lathapatil]

In Run/Debug configurations when changing Start Level/ Auto-Start for some plug-ins and apply the changes,
and closing and reopening the popup will make changes to disappear provided "Only show selected" is selected.

Fixes #311

[HannesWell]

@lathapatil thanks for this fix.

In general it looks good to me, but I couldn't test it yet.
I'll test it probably tomorrow or Wednesday, unless another committer does it before.

[github-actions]

Test Results

   264 files   -        6     264 suites   - 6   48m 43s ⏱️ - 15m 42s
3 335 tests +       1  3 304 ✔️ +       1  30 💤 ±  0  1 ❌ +1 
7 578 runs   - 2 721  7 511 ✔️  - 2 697  66 💤  - 24  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c2d2ad9. ± Comparison against base commit ec3cb35.

♻️ This comment has been updated with latest results.

[alshamams]

Hi @lathapatil ,
I have tested the changes made, and it seems to be working.

[lathapatil]

Hi @lathapatil , I have tested the changes made, and it seems to be working.

@alshamams Thanks for the confirmation

[gireeshpunathil]

what does this mean this PR removes 1 test: AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test ? @HannesWell - do you know? is this of some concern / blocker from landing?

[HannesWell]

I also tried it and it works as desired and fixes the mentioned issue.

But since CachedCheckboxTreeViewer is also used through FilteredCheckboxTree in other places, could you please verify that those other users are negatively impacted by this change? Although in general it looks reasonable what you have done.

what does this mean this PR removes 1 test: AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test ? @HannesWell - do you know? is this of some concern / blocker from landing?

I think this is just a false note. Probably the check gets confused due to the random/unrelated failure. So this is not a blocker.

[laeubi]

could you please verify that those other users are negatively impacted by this change

Didn't know that it is a goal to "negatively impact other users" :-D

[HannesWell]

Thank you @lathapatil.

could you please verify that those other users are negatively impacted by this change

Didn't know that it is a goal to "negatively impact other users" :-D

Oh course I meant not impacted, it was a little late.😅

[gireeshpunathil]

I landed it based on the assumption that the suggestion was for a future PR. hope nothing is broken!

[HannesWell]

I landed it based on the assumption that the suggestion was for a future PR. hope nothing is broken!

We'll see. In case it is, it just needs to be fixed. :)