Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable referenced repositories when resolving the target content #753

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Sep 21, 2023

Currently referenced repositories are ignored, that prevents sharing of items that are already available in the referenced repository.

This enables searching references (if possible) to find IUs and dependencies in these referenced repositories as well.

Fix #720

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Test Results

     273 files  ±0       273 suites  ±0   1h 2m 5s ⏱️ -48s
  3 340 tests ±0    3 307 ✔️ ±0  30 💤 ±0  0 ±0  3 🔥 ±0 
10 317 runs  ±0  10 224 ✔️ ±0  90 💤 ±0  0 ±0  3 🔥 ±0 

For more details on these errors, see this check.

Results for commit 31280ab. ± Comparison against base commit fcb15cb.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

To me it looks like that referenced artifact repositories also have to be considered in getArtifactRepositories(). I assume otherwise only the IU is found, but not the corresponding artifact, when using the slicer.

Would it be possible to add tests for this?

@laeubi
Copy link
Contributor Author

laeubi commented Sep 22, 2023

To me it looks like that referenced artifact repositories also have to be considered in getArtifactRepositories(). I assume otherwise only the IU is found, but not the corresponding artifact, when using the slicer.

I can enable this for slicer as well, but references are handled already in the ProvisioningContext so from PDE we only need the metadata to initially find references.

@HannesWell
Copy link
Member

To me it looks like that referenced artifact repositories also have to be considered in getArtifactRepositories(). I assume otherwise only the IU is found, but not the corresponding artifact, when using the slicer.

I can enable this for slicer as well, but references are handled already in the ProvisioningContext so from PDE we only need the metadata to initially find references.

OK great, if that works that's perfectly fine.
It should just be avoided that that for an IU found by the Planner or Slicer, the corresponding artifact is not found later if the TP is loaded.

Currently referenced repositories are ignored, that prevents sharing of
items that are already available in the referenced repository.

This enables searching references (if possible) to find IUs and
dependencies in these referenced repositories as well.

Fix eclipse-pde#720
@laeubi
Copy link
Contributor Author

laeubi commented Sep 24, 2023

I'll merge this now so we can get early feedback if it is causing any issue.

@laeubi laeubi merged commit b9141c8 into eclipse-pde:master Sep 24, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow using units from referenced updatesites
2 participants