Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a category for the layout spy #868

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Nov 3, 2023

core and ui define this org.eclipse.pde.runtime.spy.commands.category category for their command. Copying over the solution for the layout spy.

Fixes #856

Copy link

github-actions bot commented Nov 3, 2023

Test Results

   285 files  ±0     285 suites  ±0   55m 35s ⏱️ + 6m 7s
 3 581 tests ±0   3 505 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 935 runs  ±0  10 704 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 9850459. ± Comparison against base commit c9666d1.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor Author

vogella commented Nov 3, 2023

Test failiure seem unrelated see #820

@vogella vogella force-pushed the layout-spy-category branch 2 times, most recently from 844588e to c6f9e3c Compare November 7, 2023 20:54
@vogella
Copy link
Contributor Author

vogella commented Nov 7, 2023

@HannesWell WDYT? Something for RC1 or better to wait for the next release?

@HannesWell
Copy link
Member

@HannesWell WDYT? Something for RC1 or better to wait for the next release?

I have to admit I'm not familiar with that part of the code and have to understand it first.
But I assume in general this Part of PDE is not that critical?

@vogella
Copy link
Contributor Author

vogella commented Nov 8, 2023

@HannesWell WDYT? Something for RC1 or better to wait for the next release?

I have to admit I'm not familiar with that part of the code and have to understand it first. But I assume in general this Part of PDE is not that critical?

To see the layout spy in action, use Ctrl+3, Layout Spy. Please enjoy the beautiful random coloring of the IDE (resize to trigger) to find layout issues.

image

But I assume in general this Part of PDE is not that critical?

Not critical, just annoying to see a warning in your runtime IDE.

@HannesWell
Copy link
Member

But I assume in general this Part of PDE is not that critical?

Not critical, just annoying to see a warning in your runtime IDE.

I tried out this change and the state before and didn't found such warning. Can you please be more specific?

Furthermore the Extension-Point description of the o.e.ui.commands point says:
Deprecated category - Please use categoryId instead.
Considering that, I would suggest the opposite to remove the category in pde.runtime and the spy-category.name in this project.

@vogella vogella force-pushed the layout-spy-category branch from c6f9e3c to 333204f Compare November 30, 2023 15:41
@opcoach
Copy link
Contributor

opcoach commented Sep 25, 2024

@HannesWell should we squash/merge or close this issue ?

@HannesWell
Copy link
Member

@HannesWell should we squash/merge or close this issue ?

Yes lets submit this now. I haven't verified this, but Lars knows what he's doing.

Lets also see the new version increment workflow in real action 🍿

@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.tools.layout.spy/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From ebcd9fb2a7554dcaf36ec163bd99aa447cf54b41 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 25 Sep 2024 17:07:28 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/ui/org.eclipse.tools.layout.spy/META-INF/MANIFEST.MF b/ui/org.eclipse.tools.layout.spy/META-INF/MANIFEST.MF
index 1485d506e6..d3435a1fdc 100644
--- a/ui/org.eclipse.tools.layout.spy/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.tools.layout.spy/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.tools.layout.spy;singleton:=true
-Bundle-Version: 1.2.400.qualifier
+Bundle-Version: 1.2.500.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.jface.databinding;bundle-version="1.9.0",
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

vogella and others added 2 commits September 25, 2024 22:09
core and ui define this org.eclipse.pde.runtime.spy.commands.category
category for their command. Copying over the solution for the layout
spy.

Fixes #856
@HannesWell HannesWell merged commit 03ff9fb into master Sep 25, 2024
18 checks passed
@HannesWell HannesWell deleted the layout-spy-category branch September 25, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning Commands should really have a category: plug-in='org.eclipse.tools.layout.spy',
4 participants