-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a category for the layout spy #868
Conversation
Test failiure seem unrelated see #820 |
844588e
to
c6f9e3c
Compare
@HannesWell WDYT? Something for RC1 or better to wait for the next release? |
I have to admit I'm not familiar with that part of the code and have to understand it first. |
To see the layout spy in action, use Ctrl+3, Layout Spy. Please enjoy the beautiful random coloring of the IDE (resize to trigger) to find layout issues.
Not critical, just annoying to see a warning in your runtime IDE. |
I tried out this change and the state before and didn't found such warning. Can you please be more specific? Furthermore the Extension-Point description of the o.e.ui.commands point says: |
c6f9e3c
to
333204f
Compare
@HannesWell should we squash/merge or close this issue ? |
333204f
to
f2eac57
Compare
Yes lets submit this now. I haven't verified this, but Lars knows what he's doing. Lets also see the new version increment workflow in real action 🍿 |
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
core and ui define this org.eclipse.pde.runtime.spy.commands.category category for their command. Copying over the solution for the layout spy. Fixes #856
266f638
to
9850459
Compare
core and ui define this org.eclipse.pde.runtime.spy.commands.category category for their command. Copying over the solution for the layout spy.
Fixes #856