Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASE.md #2204

Closed
wants to merge 3 commits into from
Closed

Update RELEASE.md #2204

wants to merge 3 commits into from

Conversation

bravesasha
Copy link
Contributor

Fix typo

@akurtakov
Copy link
Member

Would you please sign the ECA https://www.eclipse.org/legal/eca/ ? without it we can't accept anything from you.

@laeubi
Copy link
Contributor

laeubi commented Sep 4, 2024

I tend to close this, I'm not sure what the intention of the author is to open hundreds of questionable "Fix Typo" things but I have seen a lot of them and they more look like automatically generated (by AI?) than real contributions because the author care about the project.

@bravesasha
Copy link
Contributor Author

You are wrong, there is no AI here. I just wanted to help the project, since I have no professional development skills, I try to find errors in the documentation, I agree, it does not always work. If you don't like it, I understand, I'm sorry, it won't happen again from my side

@akurtakov
Copy link
Member

If you want to contribute to the project:

  • please sign the ECA as requested in previous comment
  • Do not create merge commits but rather rebase on too of master and force push to your branch.

@bravesasha
Copy link
Contributor Author

Sorry for not replying right away. I have already signed the CLA

@bravesasha
Copy link
Contributor Author

Please explain how I can make sure that I really signed the CLA. There should be a green checkmark next to the Eclipse Contributor Agreement?

@merks
Copy link
Contributor

merks commented Sep 4, 2024

It looks like you maybe used some mangled version of your email address in the commit:

image

Is this page reachable for you?

https://api.eclipse.org/git/eca/status/gh/eclipse-platform/eclipse.platform.releng.aggregator/2204

@bravesasha
Copy link
Contributor Author

bravesasha commented Sep 4, 2024

Just checked the mail, there are no discrepancies
Yes, available

@bravesasha
Copy link
Contributor Author

I just went into Githu settings and noticed that I still have one default email with this message:

Not visible in emails
This email will not be used as the 'from' address for web-based Git operations, e.g., edits and merges. We will instead use 122097069+bravesasha@users.noreply.github.com.

@merks
Copy link
Contributor

merks commented Sep 4, 2024

A commit like this cannot be properly associated with your ECA-registered email.

image

I know you don't want to be spammed, but if you want to contribute, you commits need to be associated with an email address for which there is an associated ECA.

@bravesasha
Copy link
Contributor Author

Sorry. Please tell me how I can solve this issue. How do I link my primary email?

@bravesasha
Copy link
Contributor Author

I think I already found the solution. Please check again

@merks
Copy link
Contributor

merks commented Sep 4, 2024

I think that unless you push a new commit (just one, rebased on master) for which the email address isn't mangled it's not going to work.

@bravesasha
Copy link
Contributor Author

Maybe I should delete this commit and create a new one. Since I do not work through the terminal, but directly?

@merks
Copy link
Contributor

merks commented Sep 5, 2024

Yes. I think that if you rename your old branch, create a new branch based on master with the same name as you used this PR, you can then make changes, commit them, and force push them to your fork's branch to overwrite the commit that's there and that will update this PR.

@merks
Copy link
Contributor

merks commented Sep 5, 2024

Note too that it's generally expect that a PR will have a single commit

https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#creating-a-pull-request

So please force push a single commit.

@SougandhS
Copy link
Contributor

Maybe I should delete this commit and create a new one. Since I do not work through the terminal, but directly?
@bravesasha I have faced the same issue, the solution is to change your github username and email to the one which was used to register ECA. ie the Author and Committer id should be same

@bravesasha
Copy link
Contributor Author

thanks for the advice

@bravesasha bravesasha closed this by deleting the head repository Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants