-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RELEASE.md #2204
Update RELEASE.md #2204
Conversation
Fix typo
Would you please sign the ECA https://www.eclipse.org/legal/eca/ ? without it we can't accept anything from you. |
I tend to close this, I'm not sure what the intention of the author is to open hundreds of questionable "Fix Typo" things but I have seen a lot of them and they more look like automatically generated (by AI?) than real contributions because the author care about the project. |
You are wrong, there is no AI here. I just wanted to help the project, since I have no professional development skills, I try to find errors in the documentation, I agree, it does not always work. If you don't like it, I understand, I'm sorry, it won't happen again from my side |
If you want to contribute to the project:
|
Sorry for not replying right away. I have already signed the CLA |
Please explain how I can make sure that I really signed the CLA. There should be a green checkmark next to the Eclipse Contributor Agreement? |
It looks like you maybe used some mangled version of your email address in the commit: Is this page reachable for you? https://api.eclipse.org/git/eca/status/gh/eclipse-platform/eclipse.platform.releng.aggregator/2204 |
Just checked the mail, there are no discrepancies |
I just went into Githu settings and noticed that I still have one default email with this message: Not visible in emails |
Sorry. Please tell me how I can solve this issue. How do I link my primary email? |
I think I already found the solution. Please check again |
I think that unless you push a new commit (just one, rebased on master) for which the email address isn't mangled it's not going to work. |
Maybe I should delete this commit and create a new one. Since I do not work through the terminal, but directly? |
Yes. I think that if you rename your old branch, create a new branch based on master with the same name as you used this PR, you can then make changes, commit them, and force push them to your fork's branch to overwrite the commit that's there and that will update this PR. |
Note too that it's generally expect that a PR will have a single commit https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#creating-a-pull-request So please force push a single commit. |
|
thanks for the advice |
Fix typo