add org.eclipse.jdt.debug.jdi.tests to daily build #2322
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
force-pushed
the
org.eclipse.jdt.debug.jdi.tests
branch
2 times, most recently
from
71756b3 to
0fe38f5
Compare
|
i have no clue what these files are about, but they seem to be missing jdi. i added them like the org.eclipse.jdt.debug.tests tests. i could need some help/review here! @HeikoKlare ? |
HeikoKlare
reviewed
Sep 6, 2024
There was a problem hiding this comment.
From my understanding, you found all files that need to be touched to address the problem. Only a call of the added Ant target seems to be missing and the performance test log addition seems to be obsolete (see my comments). Once that's addressed, the PR should be good to go.
FYI: For validation, I have also taken a look at a previous plug-in addition to daily build (#2035).
eclipse.platform.releng.tychoeclipsebuilder/eclipse/publishingFiles/performanceTestManifest.xml
Outdated
Show resolved
Hide resolved
jukzi
force-pushed
the
org.eclipse.jdt.debug.jdi.tests
branch
from
0fe38f5 to
64dcef9
Compare
HeikoKlare
approved these changes
Sep 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-jdt/eclipse.jdt.debug#484