Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWT tests for win32 have API errors #1298

Closed
merks opened this issue Jun 24, 2024 · 2 comments · Fixed by #1305
Closed

SWT tests for win32 have API errors #1298

merks opened this issue Jun 24, 2024 · 2 comments · Fixed by #1305

Comments

@merks
Copy link
Contributor

merks commented Jun 24, 2024

Describe the bug

With the latest commits, there are API errors in my workspace:

image

To Reproduce

A freshly Oomphed workspace with just SWT has the problem too:

image

Expected behavior

Error freee workspace

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS
  1. Additional OS info (e.g. OS version, Linux Desktop, etc)

Windows 10

  1. JRE/JDK version

Version since

Current clone.

Workaround (or) Additional context

Delete errors.

fedejeanne added a commit to fedejeanne/eclipse.platform.swt that referenced this issue Jun 24, 2024
- Move Win32AutoscaleTestBase to package org.eclipse.swt
- Increase minor version in manifest
- Add missing @SInCE tags in extending test classes

Fixes eclipse-platform#1298
fedejeanne added a commit to fedejeanne/eclipse.platform.swt that referenced this issue Jun 24, 2024
- Move Win32AutoscaleTestBase to package org.eclipse.swt
- Increase minor version in manifest
- Add missing @SInCE tags in extending test classes

Fixes eclipse-platform#1298
fedejeanne added a commit to fedejeanne/eclipse.platform.swt that referenced this issue Jun 24, 2024
- Move Win32AutoscaleTestBase to package org.eclipse.swt
- Increase minor version in manifest
- Add missing @SInCE tags in extending test classes

Fixes eclipse-platform#1298
@iloveeclipse
Copy link
Member

The main problem is that tests were added to actual SWT production bundle, not to the test bundle!
Fix that please and no API comments will be needed.

@HeikoKlare
Copy link
Contributor

The main problem is that tests were added to actual SWT production bundle, not to the test bundle!
Fix that please and no API comments will be needed.

For the record: As discussed in #1299 and eclipse-platform/.github#203, moving these tests to a test bundle is impossible, as they are no integration or system tests (depending on public API only) but actual unit tests, which require access to packages not provided by the bundle or classes that are packaged protected. Thus, they can only be placed in a separate bundle if that bundle is a fragment (or maybe a friend of the to-be-tested packages in the production bundle). Since the to-be-tested code is already placed in a fragment and fragments of fragments are impossible, this test code can only be placed in the production bundle. In my opinion, this can/should be solved by adapting API tooling (as already discussed in #1299, if I see correctly).

merks added a commit to merks/eclipse.platform.swt that referenced this issue Jun 25, 2024
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jun 26, 2024
…e-platform#1298

This migrates the unit tests placed in the SWT win32 production
fragments to JUnit 5. The visibility of the test classes is reduced to
`packaged protected` as allowed by JUnit 5.

Fixes eclipse-platform#1298
HeikoKlare added a commit that referenced this issue Jun 26, 2024
This migrates the unit tests placed in the SWT win32 production
fragments to JUnit 5. The visibility of the test classes is reduced to
`packaged protected` as allowed by JUnit 5.

Fixes #1298
ShahzaibIbrahim pushed a commit to ShahzaibIbrahim/eclipse.platform.swt that referenced this issue Jun 28, 2024
…e-platform#1298

This migrates the unit tests placed in the SWT win32 production
fragments to JUnit 5. The visibility of the test classes is reduced to
`packaged protected` as allowed by JUnit 5.

Fixes eclipse-platform#1298
ShahzaibIbrahim pushed a commit to ShahzaibIbrahim/eclipse.platform.swt that referenced this issue Jul 3, 2024
…e-platform#1298

This migrates the unit tests placed in the SWT win32 production
fragments to JUnit 5. The visibility of the test classes is reduced to
`packaged protected` as allowed by JUnit 5.

Fixes eclipse-platform#1298
ShahzaibIbrahim pushed a commit to ShahzaibIbrahim/eclipse.platform.swt that referenced this issue Jul 3, 2024
…e-platform#1298

This migrates the unit tests placed in the SWT win32 production
fragments to JUnit 5. The visibility of the test classes is reduced to
`packaged protected` as allowed by JUnit 5.

Fixes eclipse-platform#1298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment