-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWT tests for win32 have API errors #1298
Comments
- Move Win32AutoscaleTestBase to package org.eclipse.swt - Increase minor version in manifest - Add missing @SInCE tags in extending test classes Fixes eclipse-platform#1298
- Move Win32AutoscaleTestBase to package org.eclipse.swt - Increase minor version in manifest - Add missing @SInCE tags in extending test classes Fixes eclipse-platform#1298
- Move Win32AutoscaleTestBase to package org.eclipse.swt - Increase minor version in manifest - Add missing @SInCE tags in extending test classes Fixes eclipse-platform#1298
The main problem is that tests were added to actual SWT production bundle, not to the test bundle! |
For the record: As discussed in #1299 and eclipse-platform/.github#203, moving these tests to a test bundle is impossible, as they are no integration or system tests (depending on public API only) but actual unit tests, which require access to packages not provided by the bundle or classes that are packaged protected. Thus, they can only be placed in a separate bundle if that bundle is a fragment (or maybe a friend of the to-be-tested packages in the production bundle). Since the to-be-tested code is already placed in a fragment and fragments of fragments are impossible, this test code can only be placed in the production bundle. In my opinion, this can/should be solved by adapting API tooling (as already discussed in #1299, if I see correctly). |
…e-platform#1298 This migrates the unit tests placed in the SWT win32 production fragments to JUnit 5. The visibility of the test classes is reduced to `packaged protected` as allowed by JUnit 5. Fixes eclipse-platform#1298
This migrates the unit tests placed in the SWT win32 production fragments to JUnit 5. The visibility of the test classes is reduced to `packaged protected` as allowed by JUnit 5. Fixes #1298
…e-platform#1298 This migrates the unit tests placed in the SWT win32 production fragments to JUnit 5. The visibility of the test classes is reduced to `packaged protected` as allowed by JUnit 5. Fixes eclipse-platform#1298
…e-platform#1298 This migrates the unit tests placed in the SWT win32 production fragments to JUnit 5. The visibility of the test classes is reduced to `packaged protected` as allowed by JUnit 5. Fixes eclipse-platform#1298
…e-platform#1298 This migrates the unit tests placed in the SWT win32 production fragments to JUnit 5. The visibility of the test classes is reduced to `packaged protected` as allowed by JUnit 5. Fixes eclipse-platform#1298
Describe the bug
With the latest commits, there are API errors in my workspace:
To Reproduce
A freshly Oomphed workspace with just SWT has the problem too:
Expected behavior
Error freee workspace
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:
Windows 10
Version since
Current clone.
Workaround (or) Additional context
Delete errors.
The text was updated successfully, but these errors were encountered: