Make win32 embedded tests package protected

[merks]

Fixes #1298

[github-actions]

Test Results

   422 files   - 48     422 suites   - 48   7m 41s ⏱️ - 1m 28s
 4 124 tests  - 11   4 116 ✅  - 11   8 💤 ±0  0 ❌ ±0 
16 325 runs   - 11  16 233 ✅  - 11  92 💤 ±0  0 ❌ ±0 

Results for commit 04c7622. ± Comparison against base commit f40502d.

This pull request removes 11 tests.

org.eclipse.swt.graphics.GCWin32Tests ‑ drawnElementsShouldScaleUpToTheRightZoomLevel
org.eclipse.swt.graphics.GCWin32Tests ‑ gcZoomLevelMustChangeOnShellZoomChange
org.eclipse.swt.graphics.PathWin32Tests ‑ testBoundsAreScaledWRTZoomLevel
org.eclipse.swt.graphics.PathWin32Tests ‑ testHandlesExistForEachZoomLevelInHashMap
org.eclipse.swt.graphics.PathWin32Tests ‑ testPathMustBeScaledOnZoomLevelChange
org.eclipse.swt.graphics.TextLayoutWin32Tests ‑ testGetBoundPublicAPIshouldReturnTheSameValueRegardlessOfZoomLevel
org.eclipse.swt.graphics.TransformWin32Tests ‑ testScaledTrasformMustHaveScaledValues
org.eclipse.swt.graphics.TransformWin32Tests ‑ testShouldHaveDifferentHandlesAtDifferentZoomLevels
org.eclipse.swt.widgets.ControlWin32Tests ‑ testDoNotScaleFontCorrectlyInNoAutoScaleSzenario
org.eclipse.swt.widgets.ControlWin32Tests ‑ testScaleFontCorrectlyInAutoScaleSzenario
…

[HeikoKlare]

Unfortunately, I think this will not work as package-protected classes will not be picked as test classes by a JUnit 4 runner. GitHub also reports the tests as removed as they don't appear as executed in the logs:

My understanding is that a migration to JUnit 5 is required to allow the visibility reduction.

[vogella]

In the past we removed the exported API from test packages. Tests are not API (which was confirmed a longer time ago in the PMC IIRC (before Ed joined).

[merks]

Then let's abandon this.