Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish Edge instantiation error due to invalid thread access #1013 #1015

Merged

Conversation

HeikoKlare
Copy link
Contributor

Instead of always showing a "no more handles" error, with this change an error due to invalid thread access is explicitly logged as such.

Contributes to #1013

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Test Results

   299 files  ±0     299 suites  ±0   6m 6s ⏱️ -20s
 4 098 tests ±0   4 090 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 206 runs  ±0  12 133 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 2a640ff. ± Comparison against base commit 2cdfd97.

♻️ This comment has been updated with latest results.

…ipse-platform#1013

Instead of always showing a "no more handles" error, with this change an
error due to invalid thread access is explicitly logged as such.

Contributes to
eclipse-platform#1013
@HeikoKlare HeikoKlare force-pushed the issue-1013-edge-invalid-thread branch from 7cc7e99 to 2a640ff Compare January 30, 2024 15:03
@HeikoKlare HeikoKlare marked this pull request as ready for review January 30, 2024 15:26
@vogella
Copy link
Contributor

vogella commented Jan 30, 2024

LGTM

@vogella vogella merged commit 94e9fe5 into eclipse-platform:master Jan 31, 2024
13 checks passed
@HeikoKlare HeikoKlare deleted the issue-1013-edge-invalid-thread branch January 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants