-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the control example by adding option to make Table and Tree Widgets editable #1239
Updating the control example by adding option to make Table and Tree Widgets editable #1239
Conversation
46d0340
to
196ead4
Compare
196ead4
to
67042f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahzaibIbrahim thank you for this contribution!
It looks good, just one detail: you don't need to add the controls to the SWT Custom Controls view since they are already in the SWT Controls view.
Please base your PR on top of master
instead of akoch-master-33
to improve testability,
I changed the "How to test" in the description of this PR since manual testing is also testing
...g.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/CustomControlExample.java
Outdated
Show resolved
Hide resolved
67042f6
to
743f161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last detail and then this PR is OK
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TableTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
743f161
to
308cc59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two remarks on this:
- Please format the code. There is currently a mixture of whitespace-based and tab-based indentation. Applying the auto-formatting to the changed/added code should result in proper indentation.
- Please adapt the commit message (in particular the title) to contain what the PR does and not what it might be used for. Currently the title is "Provide HiDPI Support for Multi-Monitor Environments for custom controls" but I do not see anything related to HiDPI support in the PR. Such information can be useful in the PR description, to make it easier for reviewers to understand use cases, and maybe also in the commit message, but the commit title (i.e., the first line of the commit message) should capture what the commit does and not what it might be used for.
Once these issues are addressed, I think we can also merge these improvement during freeze period as it only affects examples code that is not shipped with the SDK (just like we are allowed to still improve tests).
308cc59
to
310e7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
759e5e3
to
9e985fd
Compare
@HeikoKlare I have applied formatting now only on my changes also changed the commit message |
9e985fd
to
462c2b0
Compare
462c2b0
to
aac6dbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some further comments on code complexity and code style.
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TableTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TableTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TableTab.java
Outdated
Show resolved
Hide resolved
aac6dbb
to
3b53dfd
Compare
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/TreeTab.java
Outdated
Show resolved
Hide resolved
3b53dfd
to
ad2de40
Compare
This commit is part of testing the custom controls for multi-monitor support.
ad2de40
to
92ad33f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and for addressing my comments! The code looks good now. And the changes still work as expected.
Merging, since freeze period check only fails because of M1 promotion calendar entry, but merging is actually allowed (and the change does not affect production code anyway). |
Updating the example by adding option to make Table and Tree Widgets editable
This commit is part of testing the custom controls for multi-monitor support.
HOW TO TEST
Contributes to #62 and #127