[win32] Init nativeZoom of Tracker on creation #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
changed the title
HeikoKlare
reviewed
Jun 28, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tracker.java
Show resolved
Hide resolved
fedejeanne
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
The changes look good. Since I propose to do a separate PR for @HeikoKlare 's comment, this PR is good to go on my account.
@HeikoKlare if you agree, this PR can be merged.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tracker.java
Show resolved
Hide resolved
No, the implementation is wrong (see my comment), so it should not be merged. |
HeikoKlare
approved these changes
Jul 1, 2024
As one constructor of Tracker is not calling the super constructor the nativeZoom attribute must be set here as well. As it only has the display as reference, the zoom of the display (currently equal to primary monitor zoom) will be used. Contributes to eclipse-platform#62 and eclipse-platform#131
HeikoKlare
force-pushed
the
tracker-set-nativezoom-oncreation
branch
from
06b4342 to
f505197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one constructor of Tracker is not calling the super constructor the nativeZoom attribute must be set here as well. As it only has the display as reference, the zoom of the display (currently equal to primary monitor zoom) will be used.
Contributes to #62 and #131