-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of transform to enable Multi Zoom Level Support for Win32 #1276
Merged
fedejeanne
merged 1 commit into
eclipse-platform:master
from
amartya4256:multi_zoom_level_transform
Jun 21, 2024
Merged
Implementation of transform to enable Multi Zoom Level Support for Win32 #1276
fedejeanne
merged 1 commit into
eclipse-platform:master
from
amartya4256:multi_zoom_level_transform
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
4 times, most recently
from
June 12, 2024 11:59
5d597a6
to
a2fd51a
Compare
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
from
June 12, 2024 13:26
a2fd51a
to
c35ce40
Compare
akoch-yatta
reviewed
Jun 14, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
fedejeanne
requested changes
Jun 14, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/TransformWin32Tests.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/TransformWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/TransformWin32Tests.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/TransformWin32Tests.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/TransformWin32Tests.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
2 times, most recently
from
June 17, 2024 13:32
4ecc631
to
934b2c5
Compare
fedejeanne
requested changes
Jun 19, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
from
June 19, 2024 15:45
43f31d9
to
6ae5413
Compare
fedejeanne
previously requested changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better thank you!
Some remarks though:
- You should reduce the visibility of the new method.
- There is a failed test (a leak)
1 leaks found, the first is:
java.lang.AssertionError: 1 leaks found, the first is:
at org.eclipse.swt.tests.junit.AllNonBrowserTests.afterClass(AllNonBrowserTests.java:92)
...
Caused by: java.lang.Error: SWT Resource was not properly disposed
at org.eclipse.swt.graphics.Resource.initNonDisposeTracking(Resource.java:172)
at org.eclipse.swt.graphics.Resource.<init>(Resource.java:120)
at org.eclipse.swt.graphics.Transform.<init>(Transform.java:140)
at org.eclipse.swt.graphics.Transform.<init>(Transform.java:72)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC.test_drawLine_noSingularitiesIn45DregreeRotation(Test_org_eclipse_swt_graphics_GC.java:750)
...
Could you please look into that?
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Transform.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
2 times, most recently
from
June 20, 2024 11:24
0b75ddb
to
5884fdc
Compare
fedejeanne
force-pushed
the
multi_zoom_level_transform
branch
from
June 20, 2024 11:42
5884fdc
to
3fc1f56
Compare
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
from
June 20, 2024 11:44
3fc1f56
to
bc1b223
Compare
This commit implements the mean to provide different handles of a transform object at different zoom levels which can be consumed by GC depending on the zoom level available within its GCData. Contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
multi_zoom_level_transform
branch
from
June 20, 2024 11:46
bc1b223
to
778da20
Compare
fedejeanne
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues
Requires
Note: Only the last commit in this PR is to be reviewed. Previous commit(s) belong to the prerequisite PR(s)
Description
This pull request is based on the implementations of PR #1214. It extends to the native zoom which is provided within widget and propagated to GC. In this PR, we provide a map of different handles to Transform for different zoom levels as required by different monitors. The method win32_getHandle provides the appropriate handle for the scaled transform as per requested by the client. So far, Transform is only used by GC in the project, so all the calls from GC has been adapted to use the new method to obtasin the right handle.