Unit test writing for controls to test HiDpi #1292
Merged
+290
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 477 files - 1 477 suites - 1 9m 34s ⏱️ +6s For more details on these failures, see this check. Results for commit e7f8f16. ± Comparison against base commit 9cf9fa7. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-75
branch
4 times, most recently
from
95023a7 to
cdbd91c
Compare
|
@ShahzaibIbrahim I added
... to the description because I see you added a test class that inherits from Sorry for the inconvenience. |
ShahzaibIbrahim
force-pushed
the
master-75
branch
from
3ea6c31 to
9c19c04
Compare
|
Changed description: this PR requires #1305 |
ShahzaibIbrahim
force-pushed
the
master-75
branch
from
4158a1d to
b1a22a0
Compare
fedejeanne
requested changes
Jul 4, 2024
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-75
branch
3 times, most recently
from
6afb8da to
b3b04e1
Compare
@ShahzaibIbrahim a hint: |
ShahzaibIbrahim
force-pushed
the
master-75
branch
2 times, most recently
from
7d016ce to
a68911a
Compare
fedejeanne
requested changes
Jul 8, 2024
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Tests/win32/org/eclipse/swt/widgets/WidgetWin32Tests.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-75
branch
from
880bf28 to
0bf54a6
Compare
Since HiDpi support is added in all controls of SWT, we have provided individual unit tests wherever possible
fedejeanne
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit test for each control wherever possible in WidgetWin32Test class. Target area is testing all the properties that were affected in each control in HandleDpiChange method.
Contributes to #62 and #127
Requires