GC Data image scaling Bugfix #1301
Conversation
This commit fixes the image scaling bug in GC data. The image was scaled with the native zoom of the GC Data instead of the zoom. This leads to the the problem of no image drawn but just a white background. The image is only visible when the zoom and nativeZoom are the same. This behavior can be seen if the IDE is started at i.e. 125% zoom level on the default monitor. Hence, in this case the zoom is set to 100 and nativeZoom is 125. And due to wrong scaling, the lineNumberRulerColumn and minimize and maximize button images are not visible but rather just a white background is visible. This fix provides the right scaling to the image in the GC Data using the zoom but not the nativeZoom level as per the standard. Contributes to eclipse-platform#62 and eclipse-platform#127
|
Inspite of applying the pr, i am still not able to see the line numbers and maximize/minimize buttons. Also there is a white background covering the widgets at many places. To make it more visible i have changed to dark theme to showcase the same issue as below
|
|
The fix works for me, merging.
@deepika-u your WS seems quite "full". Which application did you start to test it? Which WS did you use? I started |
|
Sorry it works, i applied pr but missed to take child eclipse to test it. That was my miss. Thanks fede. |
... been there, done that (eclipse-platform/eclipse.platform.ui#1916 (comment)) 😅 My pleasure! 👍 |
This PR fixes the image scaling bug in GC data. The image was scaled with the native zoom of the GC Data instead of the zoom. This leads to the the problem of no image drawn but just a white background. The image is only visible when the zoom and nativeZoom are the same. This behavior can be seen if the IDE is started at i.e. 125% zoom level on the default monitor. Hence, in this case the zoom is set to 100 and nativeZoom is 125. And due to wrong scaling, the lineNumberRulerColumn and minimize and maximize button images are not visible but rather just a white background is visible.
This fix provides the right scaling to the image in the GC Data using the zoom but not the nativeZoom level as per the standard.
Contributes to #62 and #127