Removal of region constructor with handle param #1309
Conversation
amartya4256
force-pushed
the
region_remove_constructor
branch
from
f37f672 to
1c60efc
Compare
There was a problem hiding this comment.
The removals looks good to me. Only the commit message seems a little broken: "[...] and the following method win_32 [...]". @amartya4256 Would be great if you could fix that.
As an additional note on this PR: is does not only simplify the existing code, it will also simplify and improve the Windows HiDPI improvements for the Region class (#1278).
Even though the removed static method is tagged with @noreference (and even only part of an OS-specific implementation) and should thus be safe to remove, it would be great to have this confirmed by someone more experienced. Maybe @akurtakov you can give an advice whether this removal is okay?
This removal is fine as this method is only available on windows, has been properly annotated with noreference and will actually break cross platformness of the codebase if anyone has used it and even that would be quite hard as one would have to know the C pointer in order to use it proper. |
|
Thank you for the quick response and confirmation! |
amartya4256
force-pushed
the
region_remove_constructor
branch
from
1c60efc to
85c35de
Compare
This commit removes the constructor and the following method win32_new and hereby confirms that none of the clients consume them. contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
region_remove_constructor
branch
from
85c35de to
7e19604
Compare
This commit removes the constructor and the following method win32_new and hereby confirm that none of the clients consume them.
contributes to #62 and #127