Scale up magic number

[jakub-suliga]

The modification of the magic number allows for scaling up or down through DPIUtil. This only affects Radio or Check Buttons. There is no visual difference between using the magic number and DPIUtil.

These Screenshots are from the genral preferences.

Without the change on 100% zoom

With the change on 100% zoom

Without the change on 200% zoom

With the change on 200% zoom

Without the change on 100% zoom, move it to 200%.

With the change on 100% zoom, move it to 200%.

Contributes to vi-eclipse/Eclipse-Platform#72

[github-actions]

Test Results

   478 files  ±0     478 suites  ±0   7m 23s ⏱️ - 2m 11s
 4 147 tests ±0   4 139 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 354 runs  ±0  16 262 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 1106560. ± Comparison against base commit 51e85e0.

♻️ This comment has been updated with latest results.

[deepika-u]

From the look and feel perspective of this fix => i am good to go with the fix.

From code perspective, i am not sure.

[jakub-suliga]

Thank you for reviewing the code. Could you please clarify what the issue is with the code?

[fedejeanne]

@Kuba3105 you could also adapt the other assign of extra in line 354 since it's also problematic. That one you can test by adapting the Snippet206 and creating a radio or check button without text, like this:

	...
	Button button = new Button(shell, SWT.CHECK);
	button.setImage(image);
	// button.setText("Button");
	button.setBackground(display.getSystemColor(SWT.COLOR_RED)); //for better visibility during testing
	...

[jakub-suliga]

I have already adapt the other assign (see the commit 5171181). I will submit a PR soon.

[fedejeanne]

I have already adapt the other assign (see the commit 5171181). I will submit a PR soon.

You should simply add those changes to this PR (squash commits so there's always 1 commit in the PR). No need to submit another PR since it's all in the same method :-)