fix boundary condition in StyledText#getTextBounds #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance for a test case / reproducer? |
tobiasmelcher
force-pushed
the
StyledText_getTextBounds
branch
from
3a24f9e to
72c11cb
Compare
I added a unit test in Test_org_eclipse_swt_custom_StyledText and a standalone application org.eclipse.swt.examples.texteditor.mining.CodeMining which shows the problem scenario. Running org.eclipse.swt.examples.texteditor.mining.CodeMining without the fix in StyledText#getTextBounds results in two overlapping minings: With the fix, the two minings are rendered properly: I know that I introduced a cycle by adding a dependency to org.eclipse.jface.text in org.eclipse.swt.examples. I just wanted to show you the scenario in a reproducible app. Should I remove the CodeMining application from the examples plugin once you were able to reproduce it? |
...ples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/texteditor/mining/CodeMining.java
Outdated
Show resolved
Hide resolved
tobiasmelcher
force-pushed
the
StyledText_getTextBounds
branch
from
72c11cb to
ded8838
Compare
BeckerWdf
approved these changes
Jul 12, 2024
...les/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StyledText#getTextBounds returns 0x7fffffff as x value if input parameters start and end have the same value and line at the given offset is empty. This looks not correct from my point of view.
This has the effect that code minings in org.eclipse.jface.text.examples.codemining.CodeMiningDemo are not drawn correctly. Two LineHeaderCodeMinings to be drawn on the same line are then drawn on top of each other (see screenshot at eclipse-platform/eclipse.platform.ui#2024).