-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dpiutil scale calls by scale with zoom calls #1342
Merged
HeikoKlare
merged 1 commit into
eclipse-platform:master
from
amartya4256:replace_DPIUtil_calls_with_zoom
Jul 23, 2024
Merged
Replace dpiutil scale calls by scale with zoom calls #1342
HeikoKlare
merged 1 commit into
eclipse-platform:master
from
amartya4256:replace_DPIUtil_calls_with_zoom
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 478 files 478 suites 9m 24s ⏱️ Results for commit 8f417c7. ♻️ This comment has been updated with latest results. |
amartya4256
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
2 times, most recently
from
July 15, 2024 12:53
055c285
to
1e9c1b8
Compare
amartya4256
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
from
July 17, 2024 13:33
1e9c1b8
to
03f5906
Compare
HeikoKlare
reviewed
Jul 18, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Tree.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT AWT/win32/org/eclipse/swt/awt/SWT_AWT.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Widget.java
Show resolved
Hide resolved
amartya4256
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
2 times, most recently
from
July 23, 2024 11:39
fc961a4
to
6cd6837
Compare
HeikoKlare
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
from
July 23, 2024 13:43
6cd6837
to
36b0e85
Compare
HeikoKlare
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. All adaptations are sound.
akoch-yatta
reviewed
Jul 23, 2024
bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/DropTarget.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
from
July 23, 2024 14:35
36b0e85
to
55008d5
Compare
This commit replaces the DPIUtil calls from clients in win32 which are still using DPIUtil autoScale calls, with scale calls utilizing the zoom available within the clients. contributes to eclipse-platform#62 and eclipse-platform#127
HeikoKlare
force-pushed
the
replace_DPIUtil_calls_with_zoom
branch
from
July 23, 2024 14:39
55008d5
to
8f417c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1339