Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dpiutil scale calls by scale with zoom calls #1342

Conversation

amartya4256
Copy link
Contributor

Depends on #1339

Copy link
Contributor

github-actions bot commented Jul 12, 2024

Test Results

   478 files     478 suites   9m 24s ⏱️
 4 147 tests  4 139 ✅  8 💤 0 ❌
16 354 runs  16 262 ✅ 92 💤 0 ❌

Results for commit 8f417c7.

♻️ This comment has been updated with latest results.

@amartya4256 amartya4256 force-pushed the replace_DPIUtil_calls_with_zoom branch 2 times, most recently from 055c285 to 1e9c1b8 Compare July 15, 2024 12:53
@amartya4256 amartya4256 marked this pull request as ready for review July 17, 2024 13:32
@amartya4256 amartya4256 requested a review from niraj-modi as a code owner July 17, 2024 13:32
@amartya4256 amartya4256 force-pushed the replace_DPIUtil_calls_with_zoom branch from 1e9c1b8 to 03f5906 Compare July 17, 2024 13:33
@amartya4256 amartya4256 force-pushed the replace_DPIUtil_calls_with_zoom branch 2 times, most recently from fc961a4 to 6cd6837 Compare July 23, 2024 11:39
@HeikoKlare HeikoKlare force-pushed the replace_DPIUtil_calls_with_zoom branch from 6cd6837 to 36b0e85 Compare July 23, 2024 13:43
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. All adaptations are sound.

@amartya4256 amartya4256 force-pushed the replace_DPIUtil_calls_with_zoom branch from 36b0e85 to 55008d5 Compare July 23, 2024 14:35
This commit replaces the DPIUtil calls from clients in win32 which are
still using DPIUtil autoScale calls, with scale calls utilizing the zoom
available within the clients.

contributes to eclipse-platform#62 and eclipse-platform#127
@HeikoKlare HeikoKlare force-pushed the replace_DPIUtil_calls_with_zoom branch from 55008d5 to 8f417c7 Compare July 23, 2024 14:39
@HeikoKlare HeikoKlare merged commit c66545b into eclipse-platform:master Jul 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants