Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some ecj warnings: #877

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix some ecj warnings: #877

merged 2 commits into from
Nov 30, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Nov 10, 2023

set discouragedReference=ignore in snippets
set UTF-8 encoding
use try-with-resource
enable explicitlyClosedAutoCloseable=warning

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Test Results

     299 files  ±0       299 suites  ±0   5m 29s ⏱️ -11s
  4 095 tests ±0    4 087 ✔️ ±0    8 💤 ±0  0 ±0 
12 197 runs  ±0  12 124 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit a799cd7. ± Comparison against base commit 171e646.

♻️ This comment has been updated with latest results.

set discouragedReference=ignore in snippets
set UTF-8 encoding
use try-with-resource
enable explicitlyClosedAutoCloseable=warning
@jukzi jukzi merged commit 9945957 into eclipse-platform:master Nov 30, 2023
13 checks passed
@jukzi jukzi deleted the ecjwarning branch November 30, 2023 14:12
@akurtakov
Copy link
Member

Could this be related to the failure https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/PR-1531/10/console

09:26:43  [INFO] Compiling 452 source files to /home/jenkins/agent/workspace/atform.releng.aggregator_PR-1531/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.aarch64/target/classes using Eclipse Compiler for Java(TM) 3.37.0.v20231130-2255
09:26:44  [WARNING] /home/jenkins/agent/workspace/atform.releng.aggregator_PR-1531/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.aarch64/src/org/eclipse/swt/widgets/Display.java:[5992] 
09:26:44  	T[] t = (T[]) new Object[1];
09:26:44  	        ^^^^^^^^^^^^^^^^^^^
09:26:44  Type safety: Unchecked cast from Object[] to T[]
09:26:44  [WARNING] /home/jenkins/agent/workspace/atform.releng.aggregator_PR-1531/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.aarch64/src/org/eclipse/swt/widgets/Display.java:[6003] 
09:26:44  	E e = (E) ex[0];
09:26:44  	      ^^^^^^^^^
09:26:44  Type safety: Unchecked cast from Object to E

@akurtakov
Copy link
Member

No seems to be eclipse-jdt/eclipse.jdt.core#1661 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants