Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#922: Possible NPE in Menu._setVisible #923

Merged
merged 2 commits into from
Jan 3, 2024
Merged

#922: Possible NPE in Menu._setVisible #923

merged 2 commits into from
Jan 3, 2024

Conversation

tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Nov 30, 2023

No description provided.

@tmssngr tmssngr requested a review from lshanmug as a code owner November 30, 2023 13:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

Test Results

   299 files  ±0     299 suites  ±0   5m 38s ⏱️ -27s
 4 097 tests ±0   4 089 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 203 runs  ±0  12 130 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit bb23172. ± Comparison against base commit 77f7396.

♻️ This comment has been updated with latest results.

@SyntevoAlex
Copy link
Member

@lshanmug could you please review?
I refrain from that due to conflict of interests (Thomas is my boss)

@tmssngr tmssngr force-pushed the feature/922-NPE_in_Menu_setVisible branch from 3d67ea6 to bb23172 Compare December 27, 2023 10:30
merks
merks approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changing is just making it look like it does for Windows:

image

So that seems perfectly fine.

@merks merks merged commit c177563 into eclipse-platform:master Jan 3, 2024
13 checks passed
@tmssngr tmssngr deleted the feature/922-NPE_in_Menu_setVisible branch January 5, 2024 11:10
@mickaelistria mickaelistria linked an issue Jan 8, 2024 that may be closed by this pull request
[macOS] Possible NPE in Menu._setVisible #922
Closed
@mickaelistria mickaelistria mentioned this pull request Jan 8, 2024
Closed
@thahnen thahnen mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

@lshanmug lshanmug Awaiting requested review from lshanmug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] Possible NPE in Menu._setVisible
3 participants
@tmssngr @SyntevoAlex @merks