Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.eclipse.swt version due to new API #944

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

HeikoKlare
Copy link
Contributor

Follow-up for #785.

Copy link
Contributor

Test Results

     299 files  ±0       299 suites  ±0   5m 36s ⏱️ +15s
  4 097 tests ±0    4 089 ✔️ ±0    8 💤 ±0  0 ±0 
12 203 runs  ±0  12 130 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit 6d4ae3f. ± Comparison against base commit ac0c056.

@HeikoKlare HeikoKlare merged commit a74f536 into eclipse-platform:master Dec 16, 2023
13 checks passed
@HeikoKlare HeikoKlare deleted the version-fix-swt branch December 16, 2023 11:26
@laeubi
Copy link
Contributor

laeubi commented Dec 17, 2023

@HeikoKlare I suspect this now causes the build to fail see:

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/45/console

It might be that a bump in swt also needs bumps in the fragments here:

https://github.com/eclipse-platform/eclipse.platform.swt.binaries/blob/master/bundles/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF

@akurtakov can you probably advice here? I can check if I can make Tycho more patient here (as the fragment still matches the range) but wonder what was the general contract here in the past.

@laeubi
Copy link
Contributor

laeubi commented Dec 17, 2023

I have now further checked this and it is indeed the problem with this p2.inf the fragment is pulled but needs the strict version:

requires.2.range = [$version$,$version$]

so now this no longer matches what leads to the problem it not found anymore for the consumers (jface), so version bumps are required for all fragments as well!

laeubi added a commit to laeubi/eclipse.platform.swt.binaries that referenced this pull request Dec 17, 2023
laeubi added a commit to laeubi/eclipse.platform.swt.binaries that referenced this pull request Dec 17, 2023
laeubi added a commit to laeubi/eclipse.platform.swt.binaries that referenced this pull request Dec 17, 2023
iloveeclipse pushed a commit to eclipse-platform/eclipse.platform.swt.binaries that referenced this pull request Dec 17, 2023
@iloveeclipse
Copy link
Member

might be that a bump in swt also needs bumps in the fragments here

Yes.

@HeikoKlare
Copy link
Contributor Author

@laeubi Thanks for fixing the fragments versions. It would be nice to have an automated check for this implicit constraint. Maybe it will become easier to have that once the fragments are part of this repo: eclipse-platform/eclipse.platform.swt.binaries#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants