Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusLineManager: improve error with callstack #1101

Merged
merged 1 commit into from
Sep 12, 2023
Merged

StatusLineManager: improve error with callstack #1101

merged 1 commit into from
Sep 12, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Sep 12, 2023

@jukzi jukzi requested a review from laeubi September 12, 2023 09:40
@jukzi
Copy link
Contributor Author

jukzi commented Sep 12, 2023

@iloveeclipse splitted from #1100 (comment)

laeubi
laeubi approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should make it much easier to find who has called begin before...

bundles/org.eclipse.jface/src/org/eclipse/jface/action/StatusLineManager.java Outdated Show resolved Hide resolved
@jukzi jukzi force-pushed the StatusLineException branch from 1487839 to 6adbbba Compare September 12, 2023 12:09
@iloveeclipse iloveeclipse merged commit 9ee7888 into eclipse-platform:master Sep 12, 2023
@jukzi jukzi deleted the StatusLineException branch September 12, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jukzi @iloveeclipse @laeubi @EcljpseB0T