-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests #1389
base: master
Are you sure you want to change the base?
Enable tests #1389
Conversation
3f28b7a
to
85631cd
Compare
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
The failure of |
85631cd
to
6ecedac
Compare
6ecedac
to
cbfc743
Compare
Test Results 903 files ±0 903 suites ±0 45m 19s ⏱️ - 2m 21s For more details on these failures, see this check. Results for commit e4d26d6. ± Comparison against base commit c45ca46. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better. You could add a use case that checks that the order doesn't play a role and extract a private method to improve readability
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
43a69c6
to
2b3badb
Compare
bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/ButtonElement.java
Show resolved
Hide resolved
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java
Outdated
Show resolved
Hide resolved
8ef69d9
to
7e90873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testSelectPseudo
is failing. Please investigate and fix or undo changes in it
…ests/css/core/parser/MediaRulesTest.java Co-authored-by: Federico Jeanne <2205684+fedejeanne@users.noreply.github.com>
…sts/css/swt/CTabItemTest.java Don't disable test
Enabled some disabled tests which aren't in broken state anymore and fixed other disabled tests.
eclipse-platform/eclipse.platform#525
In the MediaRulesTest class, we test for if a CSS rule with @media tag is considered on parsing. Ideally we want the rule to be ignored.
Suppose we have a CSS string like:
@media screen, print {
BODY { background-color: red }
}
In the previous version of the test (which was disabled), it was expected that the rule "BODY { background-color: red }" under @media tag would be completely ignored. But now the behaviour has changed. It seems like the rules under @media are loaded indeed on parsing but the attributes are ignored, i.e. it looks like "BODY { }".
However, this behaviour doesn't have any side effect since a rule with no attributes neither change anything nor resets anything.